[PS] Migrate Resource module Authorization part to autorest v4 #27902
+2,918
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Authorization cmdlet module to use AutoRest v4 by updating generated documentation, metadata, and assembly info to align with the new code generator and add JSON-based parameter sets.
- Updated many cmdlet markdown files: removed outdated
-InputObjectsections, introducedCreateViaJsonFilePath/CreateViaJsonStringparameter sets, adjustedParameter Setsannotations, and standardized output model references. - Updated
Az.Authorization.mdand module metadata: bumped Module Guid, added new Update- cmdlets entries, and increasedAz.Accountsdependency version. - Added a generated
AssemblyInfo.csfor assembly metadata and versioning.
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/*.md | Refactored cmdlet syntax blocks, parameter sets, types, and outputs |
| docs/Az.Authorization.md | Updated help index entries, Module Guid, and dependency bump |
| README.md | Adjusted AutoRest directives |
| Properties/AssemblyInfo.cs | Added generated assembly metadata |
| Az.Authorization.nuspec | Bumped Az.Accounts dependency version |
Comments suppressed due to low confidence (2)
src/Resources/Authorization.Autorest/docs/New-AzRoleManagementPolicyAssignment.md:21
- Consider adding or updating Pester tests to cover the new JsonFilePath and JsonString parameter sets for this cmdlet.
### CreateViaJsonFilePath
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code |
There was a problem hiding this comment.
Insert a space after the period so it reads '... Code Generator. Changes may cause ...'.
Suggested change
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | |
| // Code generated by Microsoft (R) AutoRest Code Generator. Changes may cause incorrect behavior and will be lost if the code |
Copilot uses AI. Check for mistakes.
|
disable-table-view feature is missing, need confirm if this is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.