Increase maximum upload chunk to 9MB

[zxcve123]

On embedded system running virtual machines, I observe significant upload performance with higher upload chunk size.

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

• C++ Guidelines
• Doxygen docs
• Unit tests
• No unwanted commits/changes
• Descriptive title/description
  • PR is single purpose
  • Related issue listed
• Comments in source
• No typos
• Update changelog
• Not work-in-progress
• External references or docs updated
• Self review of PR done
• Any breaking changes?

[github-actions]

Thank you for your contribution @zxcve123! We will review the pull request and get back to you soon.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[antkmsft]

@zxcve123, do you happen to have any performance test for this scenario, so we could see the difference before and after? If not, would it be possible for you to write a piece of code that could demonstrate that?
Also, why 9 - not 8 or 10? How did you find out?

[zxcve123]

@zxcve123, do you happen to have any performance test for this scenario, so we could see the difference before and after? If not, would it be possible for you to write a piece of code that could demonstrate that? Also, why 9 - not 8 or 10? How did you find out?

Upload Results for 16GB in seconds:
Original Performance Test:

           54.47                   53.762                52.855

           Current Performance Test:
           
           43.736                44.327                44.864

The reason i took it 9MB is to allow stream length till 8MB. .we have a check in code at WinHttpRequest::Upload:

// Consider using `MaximumUploadChunkSize` here, after some perf measurements
size_t uploadChunkSize = DefaultUploadChunkSize;
if (streamLength < MaximumUploadChunkSize)
{
  uploadChunkSize = static_cast<size_t>(streamLength);
}

Before this change it defaults to 64KB for anything greater than 1MB.

[zxcve]

Hi Any updates on the review?

[github-actions]

Hi @zxcve123. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

[github-actions]

Hi @zxcve123. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.