-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update internal semconv classes #46537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f777681
to
0fea9fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates internal semantic convention classes in the Azure Monitor OpenTelemetry autoconfigure module to use v1.37.0 of the OpenTelemetry semantic conventions. The purpose is to maintain consistency with the latest OpenTelemetry standards while keeping the internal implementation isolated from external dependencies.
Key Changes
- Replaces usage of a single monolithic
SemanticAttributes
class with specific semantic convention classes organized by domain (HTTP, DB, URL, etc.) - Adds new semantic convention classes for both stable and incubating attributes from OpenTelemetry v1.37.0
- Updates imports and references throughout the codebase to use the new attribute classes
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
AzureMonitorMetricExporterTest.java | Updates import statements to use domain-specific semantic attribute classes |
Multiple semconv files | Adds new semantic convention attribute classes copied from OpenTelemetry v1.37.0 |
SpanDataMapper.java | Updates all semantic attribute references to use new domain-specific classes |
RequestChecker.java | Updates messaging attribute reference |
MetricDataMapper.java | Updates HTTP and RPC attribute references |
LogDataMapper.java | Updates code and thread attribute references |
AzureMonitorLogRecordExporter.java | Updates exception attribute reference |
checkstyle-suppressions.xml | Adds suppressions for new semantic convention files |
Tested in microsoft/ApplicationInsights-Java#4445