Improve comparability of benchmark, clarify use of best coding loop #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReedSolomonBenchmark runs several rounds of performance checks with a variety of CodingLoops. This was certainly helpful to determine the best variant for use in ReedSolomon.java, but may be distracting when trying to benchmark the actually used, best loop implementation across different systems and when comparing JavaReedSolomon against other implementations. Clarify that InputOutputByteTableCodingLoop is the best coding loop, expose the instance via CodingLoop.BEST_CODING_LOOP, and use that in place of a hardcoded instantiation in ReedSolomon.java. Add a commented option to ReedSolomonBenchmark that solely tests the best coding loop instead of all available loops. Morever, add a commented option to ReedSolomonBenchmark that computes bandwidth on the basis of all shards (data + parity), as done with Klaus Post's Go implementation of this library. Signed-off-by: Christian Kohlschütter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReedSolomonBenchmark runs several rounds of performance checks with a variety of CodingLoops. This was certainly helpful to determine the best variant for use in ReedSolomon.java, but may be distracting when trying to benchmark the actually used, best loop implementation across different systems and when comparing JavaReedSolomon against other implementations.
Clarify that InputOutputByteTableCodingLoop is the best coding loop, expose the instance via CodingLoop.BEST_CODING_LOOP, and use that in place of a hardcoded instantiation in ReedSolomon.java.
Add a commented option to ReedSolomonBenchmark that solely tests the best coding loop instead of all available loops.
Morever, add a commented option to ReedSolomonBenchmark that computes bandwidth on the basis of all shards (data + parity), as done with Klaus Post's Go implementation of this library.