-
Notifications
You must be signed in to change notification settings - Fork 836
Add Microphone Mute Toggle with Timed Options - Issue #1643 #2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Microphone Mute Toggle with Timed Options - Issue #1643 #2472
Conversation
Someone is attempting to deploy a commit to the kodjima33's projects Team on Vercel. A member of the Team first needs to authorize it. |
@kodjima33 @mdmohsin7 would like to get this reviewed please. |
ddc9a3a
to
02bbc13
Compare
@smian1 what do you think ? |
Awesome work! |
Superseded by clean implementation in PR #2498. This new PR has the same microphone mute feature but is built on the latest OMI codebase with only the essential changes, addressing the maintainer feedback about cleaning up unused files. |
02bbc13
to
09ecdf4
Compare
Thanks for the feedback. I cleaned it up and pushed. Let me know if you need me to fix anything else. |
@neooriginal Yes, that sounds great. I cleaned up the PR, except for the test file. I can remove that as well, just let me know. |
Youd probably want to remove that aswell - less files = better |
…r for state management with timer functionality - Add MuteToggleWidget with professional UX design - Integrate mute functionality into CaptureProvider for both device and phone audio - Support for timed mute with auto-unmute (30min, 1hr, 2hr) - Analytics tracking and persistent state management - Clean integration with latest OMI codebase - Addresses issue BasedHardware#1643
09ecdf4
to
2cd63ed
Compare
@neooriginal Thanks, and done. |
@beastoin any updates on this? |
Microphone Mute Toggle Feature - Issue #1643
/claim #1643
Description
This PR implements a comprehensive microphone mute toggle feature for the OMI app as requested in issue #1643. Users can now easily pause transcription for privacy or other reasons, then resume at any time.
Requirements Implemented
Core Requirements
Enhancement Features (Bonus)
Demo Video
Mute.Feature.mov
Implementation Details
New Files Added:
app/lib/providers/mute_provider.dart
- State management with timer functionalityapp/lib/widgets/mute_toggle_widget.dart
- Beautiful UI component with animationsapp/test/mute_provider_test.dart
- Comprehensive unit testsdocs/MICROPHONE_MUTE_FEATURE.md
- Complete documentationModified Files:
app/lib/pages/home/page.dart
- Added mute toggle to app barapp/lib/providers/capture_provider.dart
- Integrated mute functionality for both device and phone audioapp/lib/backend/preferences.dart
- Added persistent mute state storageapp/lib/main.dart
- Added MuteProvider to app provider treeKey Features:
User Experience Addresses All Issue Requirements
The implementation perfectly addresses all user needs from issue #1643:
"I don't want to touch my device; I just want to mute it"
"I still want to use the app"
"I want to look through my memories and conversations while the app is muted"
"I may be on a call that I don't want to be recorded"
"Quick tap to mute and a quick tap to unmute"
"Mute snooze feature would be amazing"
Testing
mute_provider_test.dart
📱 How It Works
Related Issues
Fixes #1643
This implementation exceeds the original requirements by adding the optional timer enhancement, comprehensive testing, beautiful animations, and production-ready code quality. Ready for review!