Some fixes for Docker library #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use frozen_string_literal magic comment instead of calling #freeze on each string. This has been supported since Ruby 2.3. * Call this 0.3.0.a1. * Update HOMEPAGE with new repository URL.
This solves the issue of running Selenium tests on Arm Mac (via Podman Desktop), among other issues.
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frozen_string_literaldeclaration at the top of ModuleInfo.#running_in_container?.The Podman check allows Selenium tests to run and pass from within Podman Desktop on my Arm Mac, and should also work for Linux systems using Podman Desktop. This also future-proofs us in case we decide to migrate from Docker to Podman at a later date.