Add new Pki::issue method that takes an IssueOptions object #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a breaking api change, duplicated the existing Pki::issue method and updated it to take an IssueOptions object. This makes the api more flexible for future api option value additions and stacking many positional arguments into the method signature.
kb
commented
Jan 20, 2020
| import java.io.IOException; | ||
| import java.nio.charset.StandardCharsets; | ||
| import java.util.Arrays; | ||
| import java.util.List; |
There was a problem hiding this comment.
Unrelated change that fixes checkstyle rule failure
kb
commented
Jan 20, 2020
| import com.bettercloud.vault.response.LogicalResponse; | ||
| import com.bettercloud.vault.vault.VaultTestUtils; | ||
| import com.bettercloud.vault.vault.mock.MockVault; | ||
| import java.util.Collections; |
There was a problem hiding this comment.
Unrelated change that fixes checkstyle rule failure
|
Addresses issue #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a breaking api change, duplicated the existing Pki::issue
method and updated it to take an IssueOptions object. This makes the
api more flexible for future api option value additions and avoids stacking
many positional arguments into the method signature.