master > staging-bitrefill merged #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously added space but only the top. Added bottom spacing now as well. Regarding the "X" button was because it's an absolute posiitoned item, so it didn't respect the top padding. Thus added extra space for its `top` property here.
``` go get github.com/BitBoxSwiss/bitbox02-api-go@99d65ac9bfd57a03cbed0f9e258ba15da9827444 go mod tidy && go mod vendor ```
This refactors the code to format amounts with fiat conversions, removing it from handlers into the coin package, and adds some tests.
``` go get github.com/BitBoxSwiss/bitbox02-api-go@7eb26c21237d6f812e6703355cccce67f6125744 go mod tidy && go mod vendor ```
Also removes the old bitbox.shop domain from the whitelist.
Signed-off-by: pullmerge <[email protected]>
This also simplifes and remove some dry code in all-accounts comp.
Android Studio was showing a lot of warnings in the Android code. This is a first step in fixing the issues and improve readability.
- ensure unit is not cut off on smaller screens - reduce coin icon size that it has the same size as on account-summary - increase space between account-name and amount so that names ending in a number do not visually belong to the amount
and fix some new linter issues.
Instead of computing the next nonce in every single ETH account, we postpone its update to right before we need it.
To reduce the amount of API calls we make to Etherscan, we bundle together updates to the balance of up to 20 ETH accounts together.
The use of creation timestamp when the tx timestamp was not available caused the app to show the current date for all the btc/ltc transactions during the header syncing. This removes the use of the tx creation timestamp, as it doesn't seem to be really useful anyway. Now during header sync the tx date is not showed at all.
This allows the component to be reused in account-summary, all-accounts, and manage-accounts.
Use connected-keystore in the sidebar. The sidebar connected icon is shown without badge text. Added a prop to force rendering the badge without text so it only shows the icon.
thisconnect
force-pushed
the
staging-bitrefill-merged
branch
from
1f968d2 to
835b84e
Compare
thisconnect
changed the title
…-merged Conflicts: CHANGELOG.md backend/exchanges/exchanges.go frontends/web/src/locales/en/app.json frontends/web/src/routes/exchange/btcdirect.tsx frontends/web/src/routes/router.tsx
thisconnect
force-pushed
the
staging-bitrefill-merged
branch
from
835b84e to
d01847e
Compare
sutterseba
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts: