Skip to content

Conversation

nathan-may
Copy link
Contributor

@nathan-may nathan-may commented Aug 25, 2025

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

closes #3444

I need to check the contributing guide, hence the draft PR. Also I think that we will need to whitelist nzd, as I receive a 400 when trying to get rates (maybe @thisconnect can do this?)

I'll test this on Android too

@nathan-may nathan-may changed the title Nm/add new zealand dollars Add new zealand dollars Aug 25, 2025
@thisconnect
Copy link
Collaborator

Thank you for your PR, yes we need to allow nzd..

In the past we were cautious with adding new fiat currencies, but
afaik we didn't have any issues in a long time... (months/years?) for this reason I strongly think we should add fiat currencies that our users request.

@benma @Beerosagos ack to add new fiat?

@nathan-may
Copy link
Contributor Author

Thank you for your PR, yes we need to allow nzd..

In the past we were cautious with adding new fiat currencies, but afaik we didn't have any issues in a long time... (months/years?) for this reason I strongly think we should add fiat currencies that our users request.

@benma @Beerosagos ack to add new fiat?

You're welcome 🙇‍♂️ and thanks for the help with tagging in people.

Looks like you added support for czk and pln in June and all good so far right? And agree, great to increase support

@benma
Copy link
Contributor

benma commented Aug 26, 2025

ACK - @thisconnect please review this PR and feel free to merge when ready.

@nathan-may nathan-may marked this pull request as ready for review August 26, 2025 10:35
@thisconnect
Copy link
Collaborator

@nathan-may we are updating the proxy to allow NZD

In the meantime please squash all commits into one commit as this should be 1 change (one logical change so it shows everything related in git blame)
https://github.com/BitBoxSwiss/bitbox-wallet-app/blob/master/CONTRIBUTING.md#git-commits

@nathan-may nathan-may force-pushed the nm/add-new-zealand-dollars branch from f23a829 to 77eb177 Compare August 28, 2025 20:37
@nathan-may
Copy link
Contributor Author

@nathan-may we are updating the proxy to allow NZD

In the meantime please squash all commits into one commit as this should be 1 change (one logical change so it shows everything related in git blame) https://github.com/BitBoxSwiss/bitbox-wallet-app/blob/master/CONTRIBUTING.md#git-commits

Cheers. I have squashed everything, hopefully ready to go now.

@thisconnect thisconnect self-requested a review August 29, 2025 05:38
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you tested LGTM

@thisconnect thisconnect merged commit fb5e44b into BitBoxSwiss:master Sep 2, 2025
10 checks passed
@nathan-may nathan-may deleted the nm/add-new-zealand-dollars branch September 2, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add New Zealand Dollars (NZD) as an option
3 participants