Skip to content

Move require statements to the beginning #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Move require statements to the beginning #6

wants to merge 9 commits into from

Conversation

Kinrany
Copy link

@Kinrany Kinrany commented Mar 27, 2019

Move all the require statements that don't have to be dynamic to the beginning of the files

monster860
monster860 requested changes Mar 27, 2019
View reviewed changes
@Kinrany
Copy link
Author

Kinrany commented Mar 27, 2019

Wait, client/lib/lighting.js depends on client/index.js, so that'll probably break something.

@monster860
Copy link
Member

yeah that too

@Kinrany
Copy link
Author

Kinrany commented Mar 28, 2019

I checked the cyclic dependencies with madge, there shouldn't be any now. Well, other than those fixed by do_resolve.

@Kinrany
Copy link
Author

Kinrany commented Mar 28, 2019

Ahh, no, just using mob/index.js won't work because everything is imported as mob.js, not just mob :s

monster860
monster860 requested changes Mar 28, 2019
View reviewed changes
@Kinrany
Copy link
Author

Kinrany commented Mar 28, 2019

Should work now. How do you test this stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@monster860 monster860 monster860 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kinrany @monster860