Skip to content

Fix postCustumApiCall: Do not add params to url #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix postCustumApiCall: Do not add params to url #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e20b33d
remove unused line and update readme
Oct 5, 2016
b219f48
add dotenv package so that .env will be read from root. update readme
Oct 5, 2016
e2c8df7
add fallback for config object and update readme to tell users both m…
Nov 6, 2016
53b3e28
remove dot env package, we dont want to force users to use any specif…
Nov 6, 2016
1d16519
add throw if missing the process environment keys to try fallback of …
Nov 6, 2016
cf703a0
fix merge conflict with master
Nov 6, 2016
5a2a51e
remove unused .env file
Nov 6, 2016
bf08828
remove unused line
Nov 6, 2016
08bfc99
fix indent tabs to spaces, give a more descriptive error throw, and c…
Nov 7, 2016
5fcc7af
postCustomApiCall: Do not add params to url
Birkenstab Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,22 @@ You need to create a [Twitter app](https://dev.twitter.com/apps) to use the API.
"callBackUrl": "XXX"
}

// make a directory in the root folder of your project called data
// copy the node_modules/twitter-node-client/twitter_config file over into data/twitter_config`
// Open `data/twitter_config` and supply your applications `consumerKey`, 'consumerSecret', 'accessToken', 'accessTokenSecret', 'callBackUrl' to the appropriate fields in your data/twitter_config file

// The twitter data can be then added via process environment variables or passed in as an object to the module.
// the preferred method is to use process environment variables to keep your keys out of github.
// If you include it on your process environment variables you can just do
var twitter = new Twitter();
// and the library will look on environment variables for your keys.
// alternatively you can
// pass a config object that will look like this below, but remember to not push these key containing files to
// github as they can be easily compromised.
// var config = {
// consumerKey='xxx'
// consumerSecret='xxx'
// accessToken='xxx'
// accessTokenSecret='xxx'
// callBackUrl='xxx'
// };
// var twitter = new Twitter(config);

//Example calls

Expand Down
69 changes: 44 additions & 25 deletions lib/Twitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,51 @@ var DEBUG = (process.env.DEBUG !== undefined);

var OAuth = require('oauth').OAuth;
var qs = require('qs');

function Twitter() {
var configPath = "data/twitter_config";
try {
var config = process.env;

this.consumerKey = config.twitterConsumerKey;
this.consumerSecret = config.twitterConsumerSecret;
this.accessToken = config.twitterAccessToken;
this.accessTokenSecret = config.twitterAccessTokenSecret;
this.callBackUrl = config.twitterCallBackUrl;
this.baseUrl = 'https://api.twitter.com/1.1';
this.oauth = new OAuth(
'https://api.twitter.com/oauth/request_token',
'https://api.twitter.com/oauth/access_token',
this.consumerKey,
this.consumerSecret,
'1.0',
this.callBackUrl,
'HMAC-SHA1'
);
} catch (err) {
//console.log(err)
function Twitter(config) {
try {
var processEnvConfig = process.env;

this.consumerKey = processEnvConfig.consumerKey;
this.consumerSecret = processEnvConfig.consumerSecret;
this.accessToken = processEnvConfig.accessToken;
this.accessTokenSecret = processEnvConfig.accessTokenSecret;
this.callBackUrl = processEnvConfig.callBackUrl;
this.baseUrl = 'https://api.twitter.com/1.1';
this.oauth = new OAuth(
'https://api.twitter.com/oauth/request_token',
'https://api.twitter.com/oauth/access_token',
this.consumerKey,
this.consumerSecret,
'1.0',
this.callBackUrl,
'HMAC-SHA1'
);
if(typeof this.consumerKey === 'undefined'){
throw new Error('missing consumer keys on process environment trying for config object');
}
}
catch (err) {
if(config){
this.consumerKey = config.consumerKey;
this.consumerSecret = config.consumerSecret;
this.accessToken = config.accessToken;
this.accessTokenSecret = config.accessTokenSecret;
this.callBackUrl = config.callBackUrl;
this.baseUrl = 'https://api.twitter.com/1.1';
this.oauth = new OAuth(
'https://api.twitter.com/oauth/request_token',
'https://api.twitter.com/oauth/access_token',
this.consumerKey,
this.consumerSecret,
'1.0',
this.callBackUrl,
'HMAC-SHA1'
);
}
else {
console.log("no 'data/twitter_config' file, continuing without...");
}
}
}

Twitter.prototype.getOAuthRequestToken = function (next) {
Expand Down Expand Up @@ -163,8 +183,7 @@ Twitter.prototype.getCustomApiCall = function (url, params, error, success) {
};

Twitter.prototype.postCustomApiCall = function (url, params, error, success) {
var path = url + this.buildQS(params);
var url = this.baseUrl + path;
var url = this.baseUrl + url;
this.doPost(url, params, error, success);
};

Expand Down