Skip to content

Fix tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: ref_migrators
Choose a base branch
from
Open

Fix tests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ __pycache__

# editors
.vscode
.idea

# Sphinx documentation
docs/_build/
Expand Down
180 changes: 3 additions & 177 deletions tests/test_migrators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import pytest
import networkx as nx

from conda_forge_tick.migrators import (JS, Version, Compiler, Noarch, Pinning, Rebuild, \
ArchRebuild, NoarchR, BlasRebuild, LicenseMigrator)
from conda_forge_tick.migrators import (Version, Rebuild, \
ArchRebuild, LicenseMigrator)
from conda_forge_tick.utils import parse_meta_yaml, frozen_to_json_friendly


Expand Down Expand Up @@ -1773,21 +1773,12 @@
- kthyng
"""

js = JS()
version = Version()
lm = LicenseMigrator()
version_license_migrator = Version(piggy_back_migrations=[lm])
compiler = Compiler()
noarch = Noarch()
noarchr = NoarchR()
perl = Pinning(removals={"perl"})
pinning = Pinning()

rebuild = Rebuild(name='rebuild', cycles=[])
rebuild.filter = lambda x: False

blas_rebuild = BlasRebuild(cycles=[])
blas_rebuild.filter = lambda x: False

test_list = [
(
Expand Down Expand Up @@ -1816,15 +1807,6 @@
},
False,
),
(
js,
sample_js,
correct_js,
{},
"Please merge the PR only after the tests have passed.",
{"migrator_name": "JS", "migrator_version": JS.migrator_version},
False,
),
(
version,
one_source,
Expand Down Expand Up @@ -1890,130 +1872,6 @@
},
False,
),
(
compiler,
sample_cb3,
correct_cb3,
{},
"N/A",
{"migrator_name": "Compiler", "migrator_version": Compiler.migrator_version},
False,
),
# It seems this injects some bad state somewhere, mostly because it isn't
# valid yaml
(
js,
sample_js2,
correct_js,
{},
"Please merge the PR only after the tests have passed.",
{"migrator_name": "JS", "migrator_version": JS.migrator_version},
False,
),
(
noarch,
sample_noarch,
updated_noarch,
{
"feedstock_name": "xpdan",
"req": [
"python",
"pip",
"numpy",
"scipy",
"matplotlib",
"pyyaml",
"scikit-beam",
"pyfai",
"pyxdameraulevenshtein",
"xray-vision",
"databroker",
"bluesky",
"streamz_ext",
"xpdsim",
"shed",
"xpdview",
"ophyd",
"xpdconf",
],
},
"I think this feedstock could be built with noarch.\n"
"This means that the package only needs to be built "
"once, drastically reducing CI usage.\n",
{"migrator_name": "Noarch", "migrator_version": Noarch.migrator_version},
False,
),
(
noarch,
sample_noarch_space,
updated_noarch_space,
{
"feedstock_name": "xpdan",
"req": [
"python",
"pip",
"numpy",
"scipy",
"matplotlib",
"pyyaml",
"scikit-beam",
"pyfai",
"pyxdameraulevenshtein",
"xray-vision",
"databroker",
"bluesky",
"streamz_ext",
"xpdsim",
"shed",
"xpdview",
"ophyd",
"xpdconf",
],
},
"I think this feedstock could be built with noarch.\n"
"This means that the package only needs to be built "
"once, drastically reducing CI usage.\n",
{"migrator_name": "Noarch", "migrator_version": Noarch.migrator_version},
False,
),
(
noarch,
sample_noarch_space,
updated_noarch_space,
{"feedstock_name": "python"},
"I think this feedstock could be built with noarch.\n"
"This means that the package only needs to be built "
"once, drastically reducing CI usage.\n",
{"migrator_name": "Noarch", "migrator_version": Noarch.migrator_version},
True,
),
(
perl,
sample_pinning,
updated_perl,
{"req": {"toolchain3", "perl", "expat"}},
"I noticed that this recipe has version pinnings that may not be needed.",
{"migrator_name": "Pinning", "migrator_version": Pinning.migrator_version},
False,
),
(
pinning,
sample_pinning,
updated_pinning,
{"req": {"toolchain3", "perl", "expat"}},
"perl: 5.22.2.1",
{"migrator_name": "Pinning", "migrator_version": Pinning.migrator_version},
False,
),
(
noarchr,
sample_r_base,
updated_r_base,
{"feedstock_name": "r-stabledist"},
"I think this feedstock could be built with noarch",
{"migrator_name": "NoarchR", "migrator_version": noarchr.migrator_version},
False,
),
(
rebuild,
sample_r_base2,
Expand All @@ -2023,36 +1881,6 @@
{"migrator_name": "Rebuild", "migrator_version": rebuild.migrator_version, "name":"rebuild"},
False,
),
(
noarchr,
sample_r_licenses_noarch,
updated_r_licenses_noarch,
{"feedstock_name": "r-stabledist"},
"I think this feedstock could be built with noarch",
{"migrator_name": "NoarchR", "migrator_version": noarchr.migrator_version},
False,
),
(
blas_rebuild,
sample_blas,
updated_blas,
{"feedstock_name": "scipy"},
"This PR has been triggered in an effort to update for new BLAS scheme.",
{"migrator_name": "BlasRebuild", "migrator_version": blas_rebuild.migrator_version, "name": "blas2"},
False,
),


# Disabled for now because the R license stuff has been purpossefully moved into the noarchR migrator
# (
# noarchr,
# sample_r_licenses_compiled,
# updated_r_licenses_compiled,
# {"feedstock_name": "r-stabledist"},
# "It is likely this feedstock needs to be rebuilt.",
# {"migrator_name": "Rebuild", "migrator_version": rebuild.migrator_version, "name":"rebuild"},
# False,
# ),
]

G = nx.DiGraph()
Expand Down Expand Up @@ -2097,10 +1925,8 @@ def test_migration(m, inp, output, kwargs, prb, mr_out, should_filter, tmpdir):
with open(os.path.join(tmpdir, "meta.yaml"), "r") as f:
actual_output = f.read()
assert actual_output == output
if isinstance(m, Compiler):
assert m.messages in m.pr_body()
# TODO: fix subgraph here (need this to be xsh file)
elif isinstance(m, Version):
if isinstance(m, Version):
pass
elif isinstance(m, Rebuild):
return
Expand Down