Skip to content

feat: add room page #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add room page #54

wants to merge 15 commits into from

Conversation

tcandicetc
Copy link

  • 顯示現在時間每間教室進行的議程名稱以及開始 / 結束時間
  • 顯示目前議程進行的進度條（目前只有 light mode 看得出來）
  • 網址加上參數 test=true 可以切換成測試模式

@netlify Netlify
Copy link

netlify bot commented May 12, 2025 •
edited
Loading

✅ Deploy Preview for velvety-pony-8aa5d9 ready!

Name Link
🔨 Latest commit e83a523
🔍 Latest deploy log https://app.netlify.com/projects/velvety-pony-8aa5d9/deploys/68357b25ac88010008ed1ecd
😎 Deploy Preview https://deploy-preview-54--velvety-pony-8aa5d9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mirumodapon
Copy link
Contributor

那個進度條看起來好讚喔🤩

@mirumodapon
Copy link
Contributor

簡單看了一下，發現這是用vue 的 options 寫法，或許可以試著幫我換成 composition api 跟其他頁面統一風格

@rileychh rileychh mentioned this pull request May 20, 2025
Merged
@tcandicetc
Copy link
Author

tcandicetc commented May 24, 2025 •
edited
Loading

Done

  • 根據進行中人數顯示擁擠程度，使用顏色漸層表示（人數目前用 random 示意而已）
  • 無進行中議程時，顯示下一場或提示「今日議程已結束」
  • 增加議程軌名稱及議程連結

TODO

  • 現在頁面左右兩邊有很多空白，嘗試調整表格寬度
  • 現在的表格在手機看起來會滿出來(?)，之後會調整

mirumodapon
mirumodapon requested changes May 24, 2025
View reviewed changes
Copy link
Contributor

@mirumodapon mirumodapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之後 git pull 記得要用 rebase 喔
git pull --rebase

@tcandicetc tcandicetc marked this pull request as ready for review May 27, 2025 08:49
mirumodapon
mirumodapon approved these changes Jun 1, 2025
View reviewed changes
Copy link
Contributor

@mirumodapon mirumodapon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起來 OK，等待年會前準備時，再次調整後合併

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirumodapon mirumodapon mirumodapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcandicetc @mirumodapon