-
-
Notifications
You must be signed in to change notification settings - Fork 65
Improve page link access and user experience #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve page link access and user experience #1178
Conversation
…cators Co-authored-by: martin.donadieu <[email protected]>
WalkthroughThe changes focus on improving accessibility, security, and semantic markup across several UI components. Enhancements include better ARIA labeling, keyboard focus styles, semantic HTML restructuring, and secure handling of external links by adding Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Navbar
participant Sidebar
participant LogTable
participant ApiKeysPage
participant ExternalSite
User->>Navbar: Focuses or clicks navigation/back/breadcrumb
Navbar-->>User: Shows focus ring, ARIA labels for screen readers
User->>Sidebar: Clicks external link/tab
Sidebar->>ExternalSite: window.open(url, '_blank', 'noopener,noreferrer')
User->>LogTable: Clicks documentation link
LogTable->>ExternalSite: window.open(DOC_LOGS, '_blank', 'noopener,noreferrer')
User->>ApiKeysPage: Clicks CLI/API doc link
ApiKeysPage->>ExternalSite: Opens link in new tab with rel="noopener noreferrer"
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (9)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
<pr_request_template>## Summary
This PR significantly enhances the user experience and accessibility of the application by addressing several UX issues related to link accessibility, navigation, and mobile usability.
Key improvements include:
rel="noopener noreferrer"
for all external links.Test plan
Tab
andShift+Tab
.rel="noopener noreferrer"
attribute is present.aria-label
changes.aria-label
.Screenshots
Please include screenshots/videos demonstrating:
Checklist
bun run lint-backend && bun run lint
.Learn more about Cursor Agents
Summary by CodeRabbit
Accessibility Improvements
Security Enhancements
noopener,noreferrer
for improved security when opening new tabs.User Interface