Skip to content

Replace Code.ensure_loaded/1 with faster counterpart #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace Code.ensure_loaded/1 with faster counterpart #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5add3
Replace Code.ensure_loaded/1 with faster counterpart
timbuchwaldt Feb 20, 2018
25f6b1b
Add fast_ensure_loaded to apps
timbuchwaldt Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/vex/validator/source.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ defimpl Vex.Validator.Source, for: Atom do
end

defp validator_by_function(source, name) do
Code.ensure_loaded(source)
FastEnsureLoaded.ensure_loaded(source)
if function_exported?(source, :validator, 1) do
check source.validator(name)
end
Expand All @@ -24,7 +24,7 @@ defimpl Vex.Validator.Source, for: Atom do
end

defp check(validator) do
Code.ensure_loaded(validator)
FastEnsureLoaded.ensure_loaded(validator)
if function_exported?(validator, :validate, 2) do
validator
end
Expand Down
4 changes: 2 additions & 2 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ defmodule Vex.Mixfile do

# Configuration for the OTP application
def application do
[applications: [:eex]]
[applications: [:eex, :fast_ensure_loaded]]
end

defp deps do
[{:ex_doc, "~> 0.16", only: :dev, runtime: false}]
[{:ex_doc, "~> 0.16", only: :dev, runtime: false}, {:fast_ensure_loaded, "~> 0.1.0"}]
end

defp package do
Expand Down
8 changes: 6 additions & 2 deletions mix.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
%{"earmark": {:hex, :earmark, "1.2.3", "206eb2e2ac1a794aa5256f3982de7a76bf4579ff91cb28d0e17ea2c9491e46a4", [], [], "hexpm"},
"ex_doc": {:hex, :ex_doc, "0.18.1", "37c69d2ef62f24928c1f4fdc7c724ea04aecfdf500c4329185f8e3649c915baf", [], [{:earmark, "~> 1.1", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm"}}
%{
"earmark": {:hex, :earmark, "1.2.3", "206eb2e2ac1a794aa5256f3982de7a76bf4579ff91cb28d0e17ea2c9491e46a4", [:mix], [], "hexpm"},
"ex_doc": {:hex, :ex_doc, "0.18.1", "37c69d2ef62f24928c1f4fdc7c724ea04aecfdf500c4329185f8e3649c915baf", [:mix], [{:earmark, "~> 1.1", [hex: :earmark, repo: "hexpm", optional: false]}], "hexpm"},
"fast_ensure_loaded": {:hex, :fast_ensure_loaded, "0.1.0", "f988c89a1e4f86d8781a2c12c60cd43772e408d0855dc487cdbcc2dc458513b5", [:mix], [{:fastglobal, "~> 1.0", [hex: :fastglobal, repo: "hexpm", optional: false]}], "hexpm"},
"fastglobal": {:hex, :fastglobal, "1.0.0", "f3133a0cda8e9408aac7281ec579c4b4a8386ce0e99ca55f746b9f58192f455b", [:mix], [], "hexpm"},
}