[SVCS-488] Improve docx rendering - OSF Part #8002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
download_url in `addon_view_file()`, which is called by `addon_view_or_download_file()`. The `is_public` comes from the node to which the file belongs.
1 task
brianjgeiger
approved these changes
Dec 11, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets and Related PRs
Service Ticket: https://openscience.atlassian.net/browse/SVCS-488
MFR PR: CenterForOpenScience/modular-file-renderer#304
Purpose
Let OSF expose whether a file is public to WB and MFR. For MFR can use an external rendering service provided by Microsoft to render public
.docxfiles.Changes
Add
publice_file = node.is_publicas query parameter to thedownload_url,which is a query parameter for the
render_url,which is returned by
addon_view_file(),which is called by route
addon_view_or_download_file().This change is based on the discussion with @sloria and @AddisonSchiller a while ago.
Side Effects
No
QA Notes
Please refer to the Service Ticket or the Service PR.
Deployments Notes
This PR must be merged before its MFR counterparts. The change won't take effect (nor cause any issues) until the MFR PR is merged.