Improve load times and desktop edition compatibility #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this idea, but we need to respect theme overrides so people can use different themes |
yusufakg
force-pushed
the
main
branch
2 times, most recently
from
6c73eb2 to
b5d8d9a
Compare
|
Done 👍 (messed up a little bit with the merge to my branch, bcs i am too tired haha, sry for that) |
|
Rebased to upstream instead of what i tried before for cleaner history. Sry again this is my first PR to open source 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves PowerShell load times by downloading the cobalt2 theme locally and removes the errors created on PowerShell Desktop i.e. PowerShell 5. It also fixes some PSScriptAnalyzer warnings for PSAvoidUsingCmdletAliases and PSUseApprovedVerbs.
PowerShell Core load
Before (fluctuates between ~6000ms to ~14000ms)
After (fluctuates between ~700ms to ~2000ms)
PowerShell Desktop load
Before
After
