Replace recursive unrolling with hard-coded unrolling #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/manual_unrolling
branch
2 times, most recently
from
63b563f to
5a077e1
Compare
dennisYatunin
changed the title
dennisYatunin
force-pushed
the
dy/manual_unrolling
branch
5 times, most recently
from
bf2399a to
a7a61bb
Compare
dennisYatunin
force-pushed
the
dy/manual_unrolling
branch
from
a7a61bb to
cb4b9bf
Compare
|
I'm also going to bump the version number, since this change represents a significant improvement in latency. |
dennisYatunin
force-pushed
the
dy/manual_unrolling
branch
from
cb4b9bf to
311b554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the recursive unrolling currently done for iterators up to length 2 with hard-coded unrolling for iterators up to length 3. This seems to minimize compilation overhead across most test cases, and it is also the pattern used in Base to unroll the
ntuple(f, ::Val{N})function.