add support for time and time64 #252
Open
+741
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR review rate limit exceeded |
|
|
serprex
reviewed
Jul 12, 2025
|
can remove empty |
Sure, was testing if things are working fine with my local clickhouse server, will clean it up. |
shivanshuraj1333
force-pushed
the
feat/issues/242
branch
3 times, most recently
from
6f4acfa to
6d3751f
Compare
|
/windsurf-review |
|
PR review rate limit exceeded |
|
working on CI failures... |
shivanshuraj1333
force-pushed
the
feat/issues/242
branch
3 times, most recently
from
30b2b2b to
e6ce37c
Compare
slvrtrn
requested changes
Jul 15, 2025
| /// Optional timezone | ||
| Time(Option<String>), | ||
| /// Precision and optional timezone | ||
| Time64(DateTimePrecision, Option<String>), |
There was a problem hiding this comment.
But it does not have a timezone?
| @@ -160,3 +176,22 @@ fn it_deserializes() { | |||
| assert_eq!(actual, sample()); | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
I'd also add a separate time/64 it for a round-trip, including corner case values
|
Clippy is fixed after #254 |
|
Thanks for the review feedbacks @slvrtrn I shall update once I'm done with the changes. |
shivanshuraj1333
force-pushed
the
feat/issues/242
branch
from
e6ce37c to
9008120
Compare
shivanshuraj1333
force-pushed
the
feat/issues/242
branch
from
6f58231 to
b5d2fc3
Compare
|
How can I trigger the CI? |
|
tested on local, CI should pass now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #242
related to ClickHouse/ClickHouse#81217
Summary
A short description of the changes with a link to an open issue.
Checklist
Delete items not relevant to your PR: