-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/Story quotes not displaying on Explorer #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Shouldn't this PR come after we've deployed the CoreNLP API then @m453h ? |
Hmm 🤔 not necessarily, if we deploy this as it is without the CoreNLP API, It wont behave any different since all requests for fetching quotes would still not get any response. We could potentially have an issue if we deploy the CoreNLP API and set the |
What I mean @m453h is: Will users see any difference before vs after deploying this PR? If yes, then all good, I'm happy for us to proceed with the PR. |
They wouldn't see the difference until we deploy the Stanford CoreNLP API, I'll create a separate issue on backstage for the deployment of the API before we proceed with merging this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deployed the CoreNLP server and add the config var to all web-tools, should be good to go @m453h
This PR fixes an issue on the

StoryQuoteTable
where quotes for a selected story are never displayed. In order for this to work we need to deploy the Stanford CoreNLP API.Fixes #56