Skip to content

Adding Meetup API #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

envythemike
Copy link

Added js/meetup.js . Just changes to css/style.css and index.html (nothing removed at all, calendar commented for testing in index.html ).

Removed Google Calendar and added direct Meetup api with Jquery(simply done right now) right where it used to be and responsive. I tested locally and works fine, I tried setting up a github page to test but I haven't used it for hosting before so js/css is broken and will have to learn how to render it properly through Github Hosting in the future. I haven't tested loading time on host. If you can test this, would be great.

Should work.

@ryanvgates
Copy link
Member

I'm not sure if I personally prefer this over the typical calendar. I think it would be better to either have the meetup calendar or have some kind of tile for each meetup. I think having the full description is too much detail. What do you think?

@envythemike
Copy link
Author

I just commented out the calendar in the index.html so it is still at the same spot and should be fine with this addition if you would like both. Last pull request I tried fixing the google calendar but realized it comes in as an Iframe so can't CSS control the calendar to be reponsive (bubble expands too big, unless a new calendar is available).

Up to you to choose. I kind of made this part 2 of my last pull request. It is very basic prototype in jquery but we could go reactjs if people would like to collaborate next meet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants