generated from mintlify/starter
-
Notifications
You must be signed in to change notification settings - Fork 121
Complete ComfyUI Custom Node Development Documentation #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
comfyui-wiki
wants to merge
10
commits into
Comfy-Org:main
Choose a base branch
from
comfyui-wiki:Update-development-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Complete ComfyUI Custom Node Development Documentation #192
comfyui-wiki
wants to merge
10
commits into
Comfy-Org:main
from
comfyui-wiki:Update-development-docs
+5,632
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Complete tips.mdx with comprehensive development lifecycle, debugging, performance optimization, best practices, testing strategies, and common pitfalls - Fill in TODO comments in datatypes.mdx with detailed information about LATENT data types, model data types (MODEL, CLIP, VAE, CONDITIONING), and complete additional parameters list - Add missing links in javascript_hooks.mdx and explain beforeRegisterNodeDef behavior - Complete server_overview.mdx missing link for dynamic INPUT_TYPES - Enhance snippets.mdx with comprehensive examples for model operations, conditioning processing, batch operations, and memory management - Expand javascript_examples.mdx with advanced examples for custom widgets, node communication, UI customization, and workflow operations - Complete workflow_templates.mdx with best practices, validation strategies, automation scripts, and community features All major TODO comments and placeholder content have been addressed with practical, actionable information for Chinese developers. Co-Authored-By: Zhixiong Lin <[email protected]>
- Modern node type definitions with ComfyNodeABC and type annotations - Virtual node implementations (Note, Markdown nodes) - Advanced primitive node patterns with widget conversion - Complex image processing nodes (mask composition, feathering) - High-performance batch processing with memory optimization - Async processing nodes with timeout and callback support - Advanced custom widgets (color picker, range slider) - Complete node lifecycle management with statistics - All examples based on actual ComfyUI/ComfyUI_frontend source code Co-Authored-By: Zhixiong Lin <[email protected]>
- Complete backend localization with file structure examples - Frontend i18n integration with dynamic language switching - Translation file formats (main.json, commands.json, settings.json) - Localization manager and utility classes - Automatic translation template generation tools - Best practices for multi-language custom node development - Based on ComfyUI CustomNodeManager.build_translations() implementation Co-Authored-By: Zhixiong Lin <[email protected]>
- Enhanced tips.mdx with complete development lifecycle, debugging, and best practices - Expanded snippets.mdx with modern node implementations and advanced patterns - Significantly enhanced javascript_examples.mdx with custom widgets and advanced UI - Addressed all TODO comments in datatypes.mdx, javascript_hooks.mdx, server_overview.mdx - Added comprehensive localization.mdx with full i18n implementation guide - Fixed remaining TODO comment in javascript_objects_and_hijacking.mdx - English docs now match Chinese documentation depth and technical quality Co-Authored-By: Zhixiong Lin <[email protected]>
- Update zh-CN javascript_objects_and_hijacking.mdx to match English version - Add comprehensive zh-CN localization.mdx documentation - Ensure Chinese docs maintain same technical depth as English versions Co-Authored-By: Zhixiong Lin <[email protected]>
…nese-custom-node-docs Complete ComfyUI Custom Node Development Documentation
…folder structure and community contribution section - Remove misleading en/, zh/, ja/ subfolder examples that are not supported by ComfyUI - Remove entire community contribution section as requested - Correct documentation to accurately reflect ComfyUI's actual internationalization capabilities - Only template display names/descriptions support i18n through frontend, not workflow JSON files themselves Co-Authored-By: Zhixiong Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete ComfyUI Custom Node Development Documentation
I used Devin to help me complete this part, but I'm not sure if it's correct and need someone to review this PR.
Overview
This PR completes the comprehensive enhancement of ComfyUI custom node development documentation, including both Chinese and English versions, focusing on backend (Python) and frontend (JavaScript) documentation improvements.
Major Changes
Chinese Documentation Completion
tips.mdx
: Complete development lifecycle, debugging techniques, performance optimization, and best practicesdatatypes.mdx
: Detailed LATENT datatype explanation, channel counts for different SD models, complete additional parameters listjavascript_hooks.mdx
: Added proper apiUpdateHandlers links and explanationsserver_overview.mdx
: Added correct documentation links for dynamic INPUT_TYPESsnippets.mdx
: Model operations, conditioning processing, batch operations, device and memory managementjavascript_examples.mdx
: Custom widgets, node communication, advanced UI customization, workflow operationsworkflow_templates.mdx
: Best practices, multilingual support, automated workflow generationEnglish Documentation Completion
tips.mdx
: Complete development lifecycle, debugging techniques, performance optimization, and best practicessnippets.mdx
: Modern node implementations using ComfyNodeABC, advanced patterns, model operations, and batch processingjavascript_examples.mdx
: Custom widgets (slider, file upload), server-client communication, advanced UI customization, workflow operationsdatatypes.mdx
,javascript_hooks.mdx
,server_overview.mdx
, andjavascript_objects_and_hijacking.mdx
localization.mdx
: Complete internationalization guide with backend and frontend integrationNew Features
localization.mdx
documentation including backend and frontend internationalization implementationComfyNodeABC
base class and type annotationsTechnical Improvements
Backend
Frontend
Internationalization
Verification
Impact
These changes will significantly improve the ComfyUI custom node development experience for both Chinese and English developers, providing:
Link to Devin run: https://app.devin.ai/sessions/a2dbd25589ef4c538f02a51f496e0305