Skip to content

feat: use number inputs in click dialog for number values #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

henrikvilhelmberglund
Copy link

@henrikvilhelmberglund henrikvilhelmberglund commented May 18, 2025

This PR makes it possible to use number input tags for number values (making it possible to press up/down to increment/decrement)

By default it uses the step value but it is also possible to press shift+up/shift+down to multiple the change by 10. (eg. step of 1 turns to 10, step of 0.1 turns to 1)

How it works in practice:
numberinputPR

This feature needs a PR in the frontend as well: Comfy-Org/ComfyUI_frontend#3926

@henrikvilhelmberglund henrikvilhelmberglund changed the title feat: use number inputs for numbers, provide step to canvas prompt feat: use number inputs for numbers May 18, 2025
@henrikvilhelmberglund henrikvilhelmberglund changed the title feat: use number inputs for numbers feat: use number inputs in click dialog for number values May 18, 2025
@webfiltered
Copy link
Contributor

I like the idea, but the design needs to be reworked. We do not want to continue adding positional params to the prompt method.

I would also recommend installing the npm tooling to save time - I can tell at a glance it would not pass eslint checks.

@henrikvilhelmberglund
Copy link
Author

I added an optionalParams object parameter and put multiline and stepValue in there, not sure if this is what you had in mind? Also created a type than can be used in the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants