Skip to content

CBST2-12: Improve External HTTP Requests #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft

Conversation

jclapis
Copy link
Collaborator

@jclapis jclapis commented Jun 10, 2025

Do not merge until #310 is complete, as this relies on it.

This is a fairly large PR that addresses numerous issues with the way external HTTP requests are handled:

  • Enforces that https is used as the scheme of any endpoints to prevent man-in-the-middle listeners
  • Adds a configurable timeout so requests don't run indefinitely
  • Reads response bodies in chunks instead of loading them all directly into memory before using them
    • Prevents handling if the Content-Length header is too large
    • If it's missing, stops if reading the response body has exceeded a size threshold (currently 10 MB)

This also modifies the SSV loader tests to use a local server with a captured (good) response instead of the canoncial SSV server.

ltitanb and others added 30 commits May 13, 2025 17:17
@jclapis jclapis self-assigned this Jun 10, 2025
@jclapis jclapis added the pbs Pbs module / Builder API label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pbs Pbs module / Builder API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants