Skip to content

Split request_signature into separate paths that return JSON #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 107 commits into from
Aug 19, 2025

Conversation

jclapis
Copy link
Collaborator

@jclapis jclapis commented Jul 29, 2025

This PR does a few things:

  1. Splits the old /request_signature route of the signer service, which took a type, into three subroutes with the types baked in:
  • /request_signature/bls
  • /request_signature/proxy-bls
  • /request_signature/proxy-ecdsa
  1. Refactors the response from the above to return a full JSON object rather than just a raw signature string, e.g.:
{
  "pubkey": "0x883827193f7627cd04e621e1e8d56498362a52b2a30c9a1c72036eb935c4278dee23d38a24d2f7dda62689886f0c39f4",
  "object_root": "0x0123456789012345678901234567890123456789012345678901234567890123",
  "module_signing_id": "0x6a33a23ef26a4836979edff86c493a69b26ccf0b4a16491a815a13787657431b",
  "signature": "0xa43e623f009e615faa3987368f64d6286a4103de70e9a81d82562c50c91eae2d5d6fb9db9fe943aa8ee42fd92d8210c1149f25ed6aa72a557d74a0ed5646fdd0e8255ec58e3e2931695fe913863ba0cdf90d29f651bce0a34169a6f6ce5b3115"
}

This provides a complete capture of everything needed to verify a signature so it can be routed into middleware without needing prior any context for validation.

ltitanb and others added 30 commits May 13, 2025 17:17
Base automatically changed from update-cbst2-02 to prevent-cross-module-sigs July 30, 2025 18:42
@jclapis jclapis marked this pull request as ready for review July 31, 2025 03:39
@jclapis jclapis changed the base branch from prevent-cross-module-sigs to sigp-audit-fixes August 19, 2025 05:02
@ltitanb ltitanb merged commit af13089 into sigp-audit-fixes Aug 19, 2025
1 of 2 checks passed
@ltitanb ltitanb deleted the signer-json-api branch August 19, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
signer Signer module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants