Skip to content

Conversation

@teacup-on-rockingchair
Copy link
Contributor

Description:

  • Make sure rsyncd service disabled rule has valid CCE for slmicro5

Rationale:

  • Add slmicro5 CCE to the rule and drop it from the available list

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 31, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair added Update Rule Issues or pull requests related to Rules updates. SLES SUSE Linux Enterprise Server product related. and removed do-not-merge/work-in-progress Used by openshift-ci bot. labels Jun 21, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.78 milestone Jun 21, 2025
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review June 21, 2025 08:03
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit d3f364b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the rsyncd disabled rule for slmicro5 by assigning it a valid CCE and ensuring it is no longer listed in the available references.

  • Removed the negative CCE entry from the available references file
  • Added the slmicro5 CCE and rsync packagename in the rule configuration
  • Introduced a new control for rsync uninstallation in the slmicro5 controls file

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
shared/references/cce-slmicro5-avail.txt Removed the negative CCE entry for slmicro5 from the available list
linux_os/guide/services/obsolete/service_rsyncd_disabled/rule.yml Added slmicro5 CCE reference and packagename for rsync
controls/general_slmicro5.yml Added a new control for uninstalling rsync in slmicro5

@jan-cerny jan-cerny self-assigned this Jul 2, 2025
@jan-cerny jan-cerny merged commit 24dba6b into ComplianceAsCode:master Jul 2, 2025
127 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants