fix(studentView): Standardize grader's student view to match actual student experience

[ncduy0303]

Description

Currently, the student's view feature for graders do not accurately represent what the student is actually seeing at the same time. What students actually see is due to what data is returned from back end, while what graders' student view see is due to the conditional check in the front end (through the graderView state)

Changes made

• Make rubric panel to be not editable in answer details view.
• Add missing access control for rubric-based response view, preventing category grades from being sent to students.
• Standardize the grader's student view to match actual student experience. It is mainly in 3 parts:
  1. question-specific information:
     • assessment settings (students can see this data when both the submission is published and the setting is on):
       • showPrivateTestCases
       • showEvaluationTestCases
       • showMcqMrqSolution
       • showRubricBreakdown
     • course settings (students can see these information when the setting is on):
       • showPublicTestCasesOutput
       • showStdoutAndStderr
  2. comments and annotations:
     • students should only see the published comments and annotations at all times
     • only graders can seeCodaveri, delayed, draft comments
  3. past attempts view (through the "All answers" button):
     • same standard as question-specific information, but this part affects the AnswerDetails component which is also used in the assessment statistics page through LastAttempt

[Copilot]

Pull Request Overview

This PR aligns the grader’s “student view” with the actual student experience by centralizing visibility flags, enforcing read-only views for students, and conditioning JSON output on grading permissions and publish state.

• Introduced a DisplaySettings type and propagated published/readOnly flags through answer components
• Made rubric panels non-editable in student-view contexts and hid unpublished annotations
• Updated view components and JSON builders to conditionally expose rubric categories, test cases, and annotations based on graderView, published, and course/assessment settings

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
client/app/types/course/assessment/submission/question/types.ts	Made aiGradingEnabled optional and categoryGrades optional
client/app/bundles/course/assessment/submission/types.ts	Added DisplaySettings interface and passed displaySettings
client/app/bundles/course/assessment/submission/containers/QuestionContent.tsx	Computed and passed published flag alongside graderView
client/app/bundles/course/assessment/submission/containers/ReadOnlyEditor.jsx	Filtered out unpublished annotations based on graderView/posts
client/app/bundles/course/assessment/submission/components/AllAttempts/AllAttemptsTimelineView.tsx	Populated displaySettings for past attempts view
app/views/course/assessment/question/rubric_based_responses/_rubric_based_response.json.jbuilder	Conditionally output rubric categories based on permissions

Comments suppressed due to low confidence (4)

client/app/bundles/course/assessment/submission/containers/ReadOnlyEditor.jsx:61

• annotations is an object, not an array, so it doesn't have a length property. To detect changes, use Object.keys(annotations).length or track the filtered annotations array length instead.

    }

client/app/bundles/course/assessment/submission/pages/SubmissionEditIndex/components/QuestionContent.tsx:50

• The published property is passed down but not declared in the component's Props interface. Please update the Props type to include published: boolean to ensure type safety.

  const published = workflowState === workflowStates.Published;

client/app/bundles/course/assessment/submission/containers/QuestionGrade.tsx:95

• The variable published is used here but not defined in this scope. Introduce const published = submission.workflowState === workflowStates.Published; before using it.

    (graderView || (published && assessment.showRubricToStudents));

client/app/bundles/course/assessment/submission/components/AllAttempts/AllAttemptsTimelineView.tsx:115

• The property assessment.showEvaluation does not exist on the assessment object. If you intended to check the display flag, use the correct field name, e.g. assessment.showEvaluationTestCases.

              graderView || (published && assessment.showEvaluation),