Fix for multipart form data without trailing CRLF #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout trailing CRLF as allowed by RFC 2046.
Cleaned up and commented code. Moved final_delim declaration outside loop and updated while loop condition to check state of final_delim instead.
|
Commit fixes #1040 |
gittiver
reviewed
Jul 23, 2025
| { | ||
| std::string delimiter = dd + boundary; | ||
| std::string normal_delim = dd + boundary; | ||
| std::string final_delim = normal_delim + dd; // Create final delimiter to check against |
There was a problem hiding this comment.
these strings are const or constexpr
gittiver
reviewed
Jul 23, 2025
| if (found == std::string::npos) | ||
| // Find next regular and final delimiter | ||
| size_t next_normal = body.find(normal_delim); | ||
| size_t next_final = body.find(final_delim); |
There was a problem hiding this comment.
this is not very effective as next_final is always one position after next_normal or not found.
So it should be sufficient to check for dd after the normal delimiter instead of do a find again over the complete string.
gittiver
requested changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified parse_body in multipart.h to support multipart form data without trailing CRLF as allowed by RFC 2046.