Skip to content

c++ implementation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

c++ implementation #3

wants to merge 4 commits into from

Conversation

lgrvs
Copy link

@lgrvs lgrvs commented Apr 13, 2018

No description provided.

lgrvs added 2 commits April 13, 2018 22:04
@lgrvs
Add files via upload
d31ef3b 
*Working* cpp implementation.
Requires gmp lib (<gmpxx.h>)
@lgrvs
Merge pull request #1 from el-famos0/el-famos0-patch-1
72e804b 
Add files via upload
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

arguiot
arguiot approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@arguiot arguiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arguiot arguiot requested a review from lukalafaye April 13, 2018 12:09
arguiot
arguiot requested changes Apr 13, 2018
View reviewed changes
Copy link
Member

@arguiot arguiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having problem running this on other platforms. Requesting a patch

@arguiot
Copy link
Member

arguiot commented Apr 14, 2018

@el-famos0 Could you add a Makefile in your PR?

Make sure you include the following command:

clang++ -L /opt/local/lib -I /opt/local/include -lgmpxx -lgmp main.cpp

@lgrvs
Add files via upload
2c6c617 
Added basic arguments support.
Multi-threading not implemented yet...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arguiot arguiot arguiot requested changes

@lukalafaye lukalafaye Awaiting requested review from lukalafaye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgrvs @CLAassistant @arguiot