Implement stacktraces in Sys::Drop()/Error()

[VReaperV]

Requires #1719

Adds stacktraces from <stacktrace> to Sys::Drop()/Error(), to help with debugging.

[illwieckz]

Thanks a lot!

[VReaperV]

error: alias declarations are a C++11 extension [-Werror,-Wc++11-extensions]

Seriously? WTF is this garbage?

[VReaperV]

GCC failure is unrelated, and for some reason using -Wno-array-bounds doesn't stop it.

[VReaperV]

I give up trying to fix that piece of shit. Either we NUKE the unsafe vec3 functions or accept the CI not using USE_CPP23 altogether, I don't care which.

[slipher]

I guess we should fix that vector load thing anyway. It could theoretically cause a segfault if the vector is right against a page boundary.

[slipher]

You might be interested in chopping the baths at build time rather instead of munging them at runtime. You can chop off the path names using the flags -fmacro-prefix-map for GCC and /d1trimfile for MSVC. So if you want to start from src you can put -fmacro-prefix-map=${CMAKE_CURRENT_SOURCE_DIR}/src=. for GCC-like, and for MSVC you do it like this:

string(REPLACE "/" "\\" backslashed_dir ${CMAKE_CURRENT_SOURCE_DIR}/src)
add_compile_options("/d1trimfile:${backslashed_dir}")

The flags can be repeated so you could do it for both Daemon and Unvanquished roots.

[VReaperV]

I've been trying this with msvc, but it doesn't seem to work with gamemodule paths for some reason.

[VReaperV]

With GCC it did not work at all for me.

[VReaperV]

Seems not a lot of packages contain libc++_backtrace. Trixie appears to have it in some of the packages. I might check at a later point if it's viable to build it and/or libc++exp for external_deps, but for now I think it's fine to not do so. Probably also need to check which of the 2 libs is present, since it's preferred to use libc++exp, but it might not be available.

[slipher]

I might check at a later point if it's viable to build it and/or libc++exp for external_deps, but for now I think it's fine to not do so.

Something with a C++ interface is probably not viable for external_deps

[VReaperV]

I might check at a later point if it's viable to build it and/or libc++exp for external_deps, but for now I think it's fine to not do so.

Something with a C++ interface is probably not viable for external_deps

Yeah.

[VReaperV]

MinGW is spewing garbage:

/home/vsts/work/1/s/src/common/StackTrace.h:47:1: note: ‘std::stacktrace’ is defined in header ‘’; did you forget to ‘#include ’?
46 | #include
+++ |+#include