Fix badly architectured audio file reads #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
force-pushed
the
fix-audio-allocs
branch
from
67dda5c to
6ba82b5
Compare
|
Added the same fix for opus files too. |
|
Very nice! |
VReaperV
force-pushed
the
fix-audio-allocs
branch
from
6ba82b5 to
b1e5c5c
Compare
|
I'm not sure what the hell happened with CI there, it never actually ran anything, and the only change I made was rebasing on master. |
slipher
reviewed
Aug 21, 2025
There was a problem hiding this comment.
This decreases the load time at start-up by easily 2x
Are you sure you're not accidentally measuring the difference between the 2 randomly selected menu soundtracks? One takes around 0.2s to load, and the other around 0.9s.
In any case, it did make a nice ~10% improvement for LoadOggCodec in my tests.
Master, short soundtrack (heartbeat1.ogg)
SoundLoader-ext N=10 min=215355us max=261480us avg=243623us tot=2436236us
This branch, short soundtrack
SoundLoader-ext N=10 min=172695us max=232609us avg=217946us tot=2179463us
Master, long soundtrack (heartbeat.ogg)
SoundLoader-ext N=10 min=820111us max=1047663us avg=921785us tot=9217856us
This branch, long soundtrack
SoundLoader-ext N=10 min=779843us max=934458us avg=837928us tot=8379280us
b1e5c5c to
3f3d3b4
Compare
VReaperV
force-pushed
the
fix-audio-allocs
branch
2 times, most recently
from
929e1cd to
0de548c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
slipher
reviewed
Aug 31, 2025
Removes most of the reallocations that happen because the file size is not known in advance.
VReaperV
force-pushed
the
fix-audio-allocs
branch
from
0de548c to
5ba5264
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most of the reallocations that happen because the file size is not known in advance.
This decreases the load time at start-up by easily 2x, and slightly improves load time for maps.