Switch to SDL3 #1752
Open
Switch to SDL3 #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
added
T-Improvement
|
Very good! Can you push it to a branch in the target repository instead so we can test it with the docker-based release script? |
|
Sure |
|
Well don't worry about it. |
|
I need it to be part of the deps update branch anyway. |
|
So I'll just cherry-pick the commit in the other PR because I need all those changes to be in the same branch for the testing to work. Pushing this branch on the target repository alone won't be enough. |
|
I imported that code in #1433: And added more SDL3 code to make it work on my end. |
|
Thx. Once it works there this pr can be closed. |
slipher
reviewed
Aug 14, 2025
| @@ -215,7 +215,7 @@ std::string KeyToString(Key key) | |||
| } | |||
|
|
|||
| int GetCharForScancode(int scancode) { | |||
| int keycode = static_cast<int>(SDL_GetKeyFromScancode(Util::enum_cast<SDL_Scancode>(scancode))); | |||
| int keycode = static_cast<int>(SDL_GetKeyFromScancode(Util::enum_cast<SDL_Scancode>(scancode), NULL, false)); | |||
There was a problem hiding this comment.
The second arg is an integer type, should be 0 not NULL
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL3 seems to work better on Wayland. Some systems don't even actually use SDL2 anymore but rather a compatibility layer.
This will also require someone to update the deps packages.