Skip to content

Evan: Week 6 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Evan: Week 6 #116

merged 5 commits into from
Jun 9, 2024

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jun 4, 2024

No description provided.

@sounmind sounmind marked this pull request as draft June 4, 2024 00:11
@sounmind sounmind marked this pull request as ready for review June 8, 2024 17:43
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image


// If the current character was seen before, update the left pointer
if (lastSeenCharIndexMap[currentChar] >= left) {
left = lastSeenCharIndexMap[currentChar] + 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 분들은 Set를 사용해서 많이 푸셨던데... Map을 사용하셔서 left 포인터를 더 효율적으로 움직이시는 부분이 인상적이네요.

@sounmind sounmind merged commit 5379515 into DaleStudy:main Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants