Skip to content

Add support for routes with interfaces #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

baldoarturo
Copy link
Contributor

Hope to close #54
I allowed for arbitrary interface names.. Would it be better to allow for interface actually related to the device itself?
Dont know if this would be a chaos based on the fact we allow multiple devices per route

image
image
image

Copy link
Owner

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added changes not related to this PR. Please correct

Copy link
Owner

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still showing the changes.

You might consider taking a patch, going back to main, creating a new clean branch, then applying the patch to that branch, then simply cleanup by removing the tag stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for routes with interfaces
2 participants