install_workflow: Exit when trying to flash v1.1.1 on 13th gen and above #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and above This copies the changes from Dasharo/meta-dts#108 to the install workflow Signed-off-by: Pawel Langowski <[email protected]>
m-iwanicki
reviewed
Mar 11, 2025
Comment on lines
+924
to
+927
| ( "$BOARD_MODEL" == "PRO Z690-A WIFI DDR4(MS-7D25)" || \ | ||
| "$BOARD_MODEL" == "PRO Z690-A DDR4(MS-7D25)" || \ | ||
| "$BOARD_MODEL" == "PRO Z690-A (MS-7D25)" || \ | ||
| "$BOARD_MODEL" == "PRO Z690-A WIFI (MS-7D25)" ) ]]; then |
There was a problem hiding this comment.
Maybe replace with "$SYSTEM_MODEL" = "MS-7D25"?
Comment on lines
+921
to
+922
| # TODO: It is not a good practice to do some target specific work in the code | ||
| # of a scallable product, this should be handled in a more scallable way: |
There was a problem hiding this comment.
Maybe
do_nothing() {
:
}
min_intel_cpu_gen() {
local min_gen=$1
local workflow=$2
if [ "$(get_intel_gen)" -lt "$min_gen" ]; then
return 1;
else
return 0;
fi
}
# use: '$PRE_DEPLOY_CHECK <deploy_workflow>'
PRE_DEPLOY_CHECK=do_nothing
(...)
case "$SYSTEM_MODEL" in
"MS-7D25")
PRE_DEPLOY_CHECK="min_intel_cpu_gen 11"
(...)
(...)
install() {
$PRE_DEPLOY_CHECK install
}That way we could create different checks for different platforms if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.