Skip to content

Local Novacustom update #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Local Novacustom update #82

wants to merge 4 commits into from

Conversation

PLangowski
Copy link
Contributor

No description provided.

@PLangowski PLangowski marked this pull request as draft April 25, 2025 07:31
@PLangowski PLangowski force-pushed the novacustom_local branch 7 times, most recently from 655bfa1 to c485433 Compare April 25, 2025 13:07
Signed-off-by: Pawel Langowski <[email protected]>
@PLangowski PLangowski changed the title wip: Local Novacustom update Local Novacustom update May 19, 2025
@PLangowski PLangowski requested a review from DaniilKl May 19, 2025 11:40
@DaniilKl
Copy link
Contributor

@PLangowski, why this PR is in draft state?

@DaniilKl
Copy link
Contributor

I am not sure if we want to merge it in main. Maybe we should keep it on a separate branch as a temporary solution?

@DaniilKl
Copy link
Contributor

DaniilKl commented May 26, 2025

Things to address:

  1. Consider removing searching HCL report on cloud option:

    ~/Projects/DTS/dts-scripts on novacustom_local λ grep -rn CMD_CLOUD_LIST 
    include/dts-environment.sh:105:CMD_CLOUD_LIST="/usr/sbin/cloud_list"
    scripts/dasharo-deploy.sh:1184:      ${CMD_CLOUD_LIST} $uuid
  2. Comment out sending anything to cloud in reports/dasharo-hcl-report.sh.

  3. Make sure the user will not se the option DPP_KEYS_OPT in main menu.

  4. Make sure that DTS will not present any messages that will mention sending smth somewhere, e.g.: Thank you for contributing to the Dasharo development!.

  5. Make sure that DTS will not ask for sending logs (note: we still want DTS to save logs locally for users to be able to send these logs in case of issues).

  6. Comment out sync_clocks

  7. Comment out subscription_routine

@PLangowski
Copy link
Contributor Author

@DaniilKl It's in draft because we are waiting for the binaries to be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants