Skip to content

dasharo-security/tpm-support.robot: Add coverage for TPM 1.2 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SebastianCzapla
Copy link
Contributor

Add new keyword that allows conditional check of tpm commands. For TPM 1.2 tools, tpm_selftest prints out "TPM Test Results:", otherwise, it prints out error message (in case if no TPM or TPM 2.0)

Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM any logs from tests on both TPM1.2 and TPM2.0?

@SebastianCzapla
Copy link
Contributor Author

Is it possible to merge this patch as is currently? The solution to duplication of tests mentioned by Krystian is tracked under following links:
Issue: #495
PR: #507

Copy link
Contributor

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for CI, just in case.

@miczyg1
Copy link
Contributor

miczyg1 commented Oct 7, 2024

The CI failed on entering to Shell in QEMU... Rather not related to the changes, they don;t even touch the failed test.

Add new keyword that allows conditional check of tpm commands.
For TPM 1.2 tools, tpm_selftest prints out "TPM Test Results:",
otherwise, it prints out error message (in case if no TPM or TPM 2.0)

Signed-off-by: Sebastian Czapla <[email protected]>
@macpijan macpijan force-pushed the tpm_support_coverage_fix branch from d13cd29 to 9f9f498 Compare October 14, 2024 14:52
@macpijan macpijan merged commit 9f9f498 into develop Oct 14, 2024
1 check failed
@macpijan macpijan deleted the tpm_support_coverage_fix branch October 14, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants