Ci on hw fixes #938
Merged
Ci on hw fixes #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Pijanowski <[email protected]>
Signed-off-by: Maciej Pijanowski <[email protected]>
Signed-off-by: Maciej Pijanowski <[email protected]>
macpijan
commented
Jul 15, 2025
philipanda
reviewed
Jul 16, 2025
Signed-off-by: Maciej Pijanowski <[email protected]>
philipanda
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Everything looks good to me apart from this topic https://github.com/Dasharo/open-source-firmware-validation/pull/938/files#r2206975056
These are lists, not single variables, so should not be compared against
${EMPTY} or ''.
Also, set the default variables to empty lists, rather than TBD string.
Signed-off-by: Maciej Pijanowski <[email protected]>
philipanda
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing flags on some platforms is a common failure during regression testing.
The goal here is to have a pre-commit which checks if the newly added flags are defined in default.robot.
That was the script execution result here: https://paste.dasharo.com/?bea619207b960492#8Kr1hUr4D37CXoaC5KpPZpy5UFaZ4Ujqy9W7cyeKgxfp