-
Notifications
You must be signed in to change notification settings - Fork 156
👷 publish datadog-flagging CDN bundle #3579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/to-staging |
View all feedbacks in Devflow UI.
Commit f47262097f will soon be integrated into staging-22.
Commit f47262097f has been merged into staging-22 in merge commit b409e5f53f. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: f472620 Co-authored-by: leoromanovsky <[email protected]>
f472620
to
48aa90f
Compare
/to-staging |
View all feedbacks in Devflow UI.
Commit 48aa90f4b4 will soon be integrated into staging-22.
We couldn't automatically merge the commit 48aa90f4b4 into staging-22. What to do next?
If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3579 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 319 319
Lines 8109 8109
Branches 1833 1833
=======================================
Hits 7489 7489
Misses 620 620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/to-staging |
View all feedbacks in Devflow UI.
Commit b12c5d6434 will soon be integrated into staging-22.
Commit b12c5d6434 has been merged into staging-22 in merge commit f591458c4f. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: b12c5d6 Co-authored-by: leoromanovsky <[email protected]>
Motivation
To create a staging dogfood app, we need to consume the flagging (open feature) SDK from the staging CDN path. It is not published now.
Changes
Adds the flagging package to publishable assets list which should make it distributable over the CDN.
It remains
private
(https://github.com/DataDog/browser-sdk/blob/main/packages/flagging/package.json#L5) so should not land on npm for production deploys.Test instructions
❓ I deployed to staging and expected to be able to resolve the JS bundle here: https://d20xtzwzcl0ceb.cloudfront.net/datadog-flagging-canary.js but it's not present.
Checklist