Skip to content

👷 publish datadog-flagging CDN bundle #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leoromanovsky
Copy link
Contributor

@leoromanovsky leoromanovsky commented May 28, 2025

Motivation

To create a staging dogfood app, we need to consume the flagging (open feature) SDK from the staging CDN path. It is not published now.

Changes

Adds the flagging package to publishable assets list which should make it distributable over the CDN.

It remains private (https://github.com/DataDog/browser-sdk/blob/main/packages/flagging/package.json#L5) so should not land on npm for production deploys.

Test instructions

❓ I deployed to staging and expected to be able to resolve the JS bundle here: https://d20xtzwzcl0ceb.cloudfront.net/datadog-flagging-canary.js but it's not present.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@leoromanovsky
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 28, 2025

View all feedbacks in Devflow UI.

2025-05-28 23:29:43 UTC ℹ️ Start processing command /to-staging


2025-05-28 23:29:49 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 24m40s (p90)

Commit f47262097f will soon be integrated into staging-22.


2025-05-28 23:46:38 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit f47262097f has been merged into staging-22 in merge commit b409e5f53f.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-22

dd-mergequeue bot added a commit that referenced this pull request May 28, 2025
@leoromanovsky leoromanovsky force-pushed the leo.romanovsky/publish-flagging branch from f472620 to 48aa90f Compare May 29, 2025 10:41
@leoromanovsky
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 29, 2025

View all feedbacks in Devflow UI.

2025-05-29 10:44:10 UTC ℹ️ Start processing command /to-staging


2025-05-29 10:44:16 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 24m40s (p90)

Commit 48aa90f4b4 will soon be integrated into staging-22.


2025-05-29 10:47:54 UTC 🚨 Branch Integration: The build pipeline contains failing jobs for this merge request

We couldn't automatically merge the commit 48aa90f4b4 into staging-22.
Build pipeline has failing jobs for 21a465b:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with /create-fix-branch -b staging-22

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (2ba9274) to head (b12c5d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3579   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         319      319           
  Lines        8109     8109           
  Branches     1833     1833           
=======================================
  Hits         7489     7489           
  Misses        620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leoromanovsky
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented May 29, 2025

View all feedbacks in Devflow UI.

2025-05-29 11:11:20 UTC ℹ️ Start processing command /to-staging


2025-05-29 11:11:27 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 24m40s (p90)

Commit b12c5d6434 will soon be integrated into staging-22.


2025-05-29 11:27:14 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit b12c5d6434 has been merged into staging-22 in merge commit f591458c4f.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-22

dd-mergequeue bot added a commit that referenced this pull request May 29, 2025
@leoromanovsky leoromanovsky marked this pull request as ready for review May 29, 2025 11:35
@leoromanovsky leoromanovsky requested a review from a team as a code owner May 29, 2025 11:35
@leoromanovsky leoromanovsky requested a review from typotter May 29, 2025 11:35
@BenoitZugmeyer BenoitZugmeyer changed the title 👷 publish datadog-flagging package 👷 publish datadog-flagging CDN bundle May 30, 2025
@leoromanovsky leoromanovsky marked this pull request as draft June 3, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants