-
Notifications
You must be signed in to change notification settings - Fork 156
β¨ FFL-16 Precomputed flags evaluation #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
OpenFeature recommends relying on web-sdk package instead of core. The downside is that web-sdk is not side-effect free, so it's better if we don't depend on StandardResolutionReasons. The good news is that TypeScript should be able to check literals against enum and using 'DEFAULT' literal is shorter and reduces bundle size a bit.
Remove peer dependencies from `dependencies` list. Also use caret range, so users are free to select SDK version.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 92.33% 92.12% -0.22%
==========================================
Files 319 322 +3
Lines 8104 8161 +57
Branches 1831 1840 +9
==========================================
+ Hits 7483 7518 +35
- Misses 621 643 +22 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
@@ -1,5 +1,5 @@ | |||
{ | |||
"name": "@datadog/browser-flagging", | |||
"name": "@datadog/openfeature-provider", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: (as discussed) it could be nice to rename the package folder as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My notes from the conversation was we left it without consensus but I am ok revisiting it as the SDK scope becomes more clear; there might be more than just the openfeature provided being exported; perhaps where we will land is a core flagging package (here or in a shared javascript repository with react native) and openfeature provider as a wrapper on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
Bundles Sizes Evolution
π CPU Performance
π§ Memory Performance
π RealWorld |
Motivation
Precomputed flags evaluation + small fixes on top of #3554.
π Open Bug: unit tests were failing in chrome 63 (https://gitlab.ddbuild.io/DataDog/browser-sdk/-/jobs/959532643) and trying to fix with changes to polyfill.
Changes
See individual commits for more details.
Test instructions
Checklist