Skip to content

temporarily add authorization via api key #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: flagging-dev
Choose a base branch
from

Conversation

leoromanovsky
Copy link
Contributor

Motivation

Changes

temporarily augmenting the sdk to accept api keys, which are normally for server context, to be able to authenticate with the backend service.

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (3e7aba7) to head (dddd3cc).

Files with missing lines Patch % Lines
packages/flagging/src/openfeature/provider.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           flagging-dev    #3604   +/-   ##
=============================================
  Coverage         92.15%   92.15%           
=============================================
  Files               326      326           
  Lines              8192     8192           
  Branches           1850     1851    +1     
=============================================
  Hits               7549     7549           
  Misses              643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leoromanovsky leoromanovsky marked this pull request as ready for review June 5, 2025 21:43
@leoromanovsky leoromanovsky requested a review from a team as a code owner June 5, 2025 21:43
Copy link

cit-pr-commenter bot commented Jun 5, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.84 KiB 146.84 KiB 0 B 0.00%
Rum Recorder 18.02 KiB 18.02 KiB 0 B 0.00%
Rum Profiler 4.63 KiB 4.63 KiB 0 B 0.00%
Logs 51.60 KiB 51.60 KiB 0 B 0.00%
Flagging 0 B 25.95 KiB 25.95 KiB N/A%
Rum Slim 106.47 KiB 106.47 KiB 0 B 0.00%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.009 0.008 -0.001
addaction 0.024 0.025 0.001
addtiming 0.007 0.005 -0.002
adderror 0.027 0.026 -0.001
startstopsessionreplayrecording 0.001 0.001 -0.000
startview 0.007 0.007 -0.001
logmessage 0.046 0.038 -0.008
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 25.93 KiB 27.20 KiB 1.27 KiB
addaction 52.86 KiB 57.04 KiB 4.18 KiB
addtiming 25.52 KiB 26.41 KiB 907 B
adderror 57.30 KiB 58.35 KiB 1.05 KiB
startstopsessionreplayrecording 25.21 KiB 25.10 KiB -115 B
startview 430.34 KiB 432.38 KiB 2.04 KiB
logmessage 55.13 KiB 60.52 KiB 5.40 KiB

🔗 RealWorld

@typotter typotter mentioned this pull request Jun 28, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants