-
Notifications
You must be signed in to change notification settings - Fork 157
✨ [RUM-246] Support prerendered pages for web vitals #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BeltranBulbarellaDD
wants to merge
24
commits into
main
Choose a base branch
from
beltran.bulbarella/RUM-246-support-prerendered-pages-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
✨ [RUM-246] Support prerendered pages for web vitals #3617
BeltranBulbarellaDD
wants to merge
24
commits into
main
from
beltran.bulbarella/RUM-246-support-prerendered-pages-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
- Coverage 92.21% 92.14% -0.07%
==========================================
Files 326 328 +2
Lines 8182 8228 +46
Branches 1849 1869 +20
==========================================
+ Hits 7545 7582 +37
- Misses 637 646 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5ca9819
to
31361ac
Compare
042bba6
to
158a758
Compare
This reverts commit e7136a7.
…cs functions (single point of calculation in trackPrerenderMetrics)
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Chrome released prerendering support for Chrome 108+ and Edge 108+. This means that all load-related metrics should be relative to when the page was "activated" rather than when it started loading (for non-prerendered pages these values are the same).
Changes
Created interface DocumentWithPrerendering.
Created function getActivationStart which uses the new activationStart.
Adjusted LCP, FCP, TTFB and firstHidden for this new calculation.
Test instructions
All previous tests should pass, and when we mock activation start or have 2 html files where 1 prerenders the other we should see something similar to the image below.
Screen.Recording.2025-06-26.at.10.06.08.mov
Checklist