🐛 [RUM-5645] Add a ff to avoid using "fetch keepalive" #3640
Conversation
rgaignault
force-pushed
the
romanG/avoid-keepalive-when-page-not-exiting
branch
from
179593e to
d4c9d08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
=======================================
Coverage 92.22% 92.23%
=======================================
Files 313 313
Lines 8041 8044 +3
Branches 1815 1816 +1
=======================================
+ Hits 7416 7419 +3
Misses 625 625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }) | ||
|
|
||
| it('should use regular fetch (without keepalive) when feature flag is enabled', async () => { | ||
| addExperimentalFeatures([ExperimentalFeature.AVOID_FETCH_KEEPALIVE]) |
There was a problem hiding this comment.
suggestion: just use mockExperimentalFeatures, so you don't need to reset them
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit d4c9d08886 will soon be integrated into staging-27.
Commit d4c9d08886 has been merged into staging-27 in merge commit b6272ddf00. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
…taging-27 Integrated commit sha: d4c9d08 Co-authored-by: rgaignault <[email protected]>
rgaignault
changed the title
Motivation
Currently, the Browser SDK uses fetch keepalive to send data to Datadog when it is supported (see code).
Because browsers enforce a limit on the amount of data that can be sent by “fetch keepalive” requests at the same time, it can impact some websites when it also use “fetch keepalive”
Changes
We could avoid using fetch keepalive to send data to Datadog when the page is sending request. For the moment we want to test it with a a feature flag
Test instructions
Checklist