Skip to content

profiler: use faster gzip for delta decompression #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

For delta profiles, use github.com/klauspost/compress/gzip rather than
compress/gzip.

Motivation

It's faster, and we already use it for other decompression after introducing
recompression to zstd, so we might as well use it for decompressing during
delta computeation too.

@nsrip-dd nsrip-dd force-pushed the push-ulqypuyoyylv branch from 2ee9460 to ba265ab Compare June 3, 2025 14:57
Base automatically changed from push-ulqypuyoyylv to main June 3, 2025 15:20
@nsrip-dd nsrip-dd force-pushed the push-luqzotwszlpp branch from d26acd8 to cda8088 Compare June 3, 2025 15:25
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025

Benchmarks

Benchmark execution time: 2025-06-04 12:40:13

Comparing candidate commit 6840c86 in PR branch push-luqzotwszlpp with baseline commit b7ba964 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

For delta profiles, use github.com/klauspost/compress/gzip rather than
compress/gzip. It's faster, and we already use it for other
decompression after introducing recompression to zstd, so we might as
well use it for decompressing during delta computeation too.
@nsrip-dd nsrip-dd force-pushed the push-luqzotwszlpp branch from cda8088 to 6840c86 Compare June 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant