Skip to content

internal/stableconfig: Report config ID to telemetry #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mtoffl01
Copy link
Contributor

…rt default origin<!--

  • New contributors are highly encouraged to read our
    CONTRIBUTING documentation.
  • Commit and PR titles should be prefixed with the general area of the pull request's change.

-->

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running golangci-lint run locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-10 18:35:04

Comparing candidate commit 98cab07 in PR branch mtoff/scfg_config_id with baseline commit bec204b in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

scenario:BenchmarkMetrics/count/get-handle-24

  • 🟥 execution_time [+5.988ns; +7.672ns] or [+2.019%; +2.587%]

scenario:BenchmarkMetrics/distribution/get-handle-24

  • 🟥 execution_time [+4.447ns; +5.413ns] or [+2.003%; +2.438%]

scenario:BenchmarkMetrics/rate/get-handle-24

  • 🟥 execution_time [+7.015ns; +10.485ns] or [+2.336%; +3.491%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant