contrib/gin-gonic/gin: refactor Option, deprecate OptionFn #3650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
force-pushed
the
contrib-gin-OptionFn
branch
from
fd98e83 to
ffd0494
Compare
Refactor Options handling. Deprecate OptionFn which was an implementation detail that is not needed anymore. This change is fully source compatible with existing client code. Also, as implementation details are now hidden behind the private 'option' type, the API is more future-proof. Full rationale for this change: DataDog#3612 Note: golangci-lint 2.1.6 reports lint error "unexported-return: exported func WithAnalytics returns unexported type gin.Option, which can be annoying to use (revive)" However this is false positive that I have reported in mgechev/revive#1406. Signed-off-by: Olivier Mengué <[email protected]>
dolmen
force-pushed
the
contrib-gin-OptionFn
branch
from
ffd0494 to
604795a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Full rationale for this change: see discussion #3612
contrib/gin-gonic/gin.Options handling.OptionFnwhich was an implementation detail that is not needed anymore.This change is fully source compatible with existing client code. Also, as implementation details are now hidden behind the new private
optiontype, the API is more future-proof.Motivation
API cleanup.
Full rationale for this change: #3612
Reviewer's Checklist
golangci-lint runlocally.Unsure? Have a question? Request a review!