-
Notifications
You must be signed in to change notification settings - Fork 462
chore: remove deprecated non_active_span argument #14898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0-breaking-changes
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 6 ms. The average import time from base is: 246 ± 3 ms. The import time difference between this PR and base is: 0.4 ± 0.2 ms. The difference is not statistically significant (z = 1.82). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate remove-non-active-span (815fe7c) with baseline 4.0-breaking-changes (3128327) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.490ms (SLO: <22.300ms -8.1%) vs baseline: ~same Memory: ✅ 65.478MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: +0.3% Memory: ✅ 64.574MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.523ms (SLO: <22.250ms -7.8%) vs baseline: -0.3% Memory: ✅ 65.434MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.253ms (SLO: <16.550ms -7.8%) vs baseline: -0.7% Memory: ✅ 53.740MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.597ms (SLO: <21.750ms -5.3%) vs baseline: +0.4% Memory: ✅ 65.437MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.264ms (SLO: <28.200ms 📉 -10.4%) vs baseline: -0.3% Memory: ✅ 67.562MB (SLO: <69.500MB -2.8%) vs baseline: +3.3% ✅ tracerTime: ✅ 20.531ms (SLO: <21.750ms -5.6%) vs baseline: ~same Memory: ✅ 65.418MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.000ms (SLO: <23.500ms -6.4%) vs baseline: -0.1% Memory: ✅ 66.565MB (SLO: <67.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.373ms (SLO: <21.500ms -9.9%) vs baseline: +0.1% Memory: ✅ 65.503MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.601ms (SLO: <17.500ms -5.1%) vs baseline: +0.1% Memory: ✅ 65.458MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 20.448ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 71.511MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-no-cachesTime: ✅ 18.481ms (SLO: <19.650ms -5.9%) vs baseline: ~same Memory: ✅ 65.442MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.744ms (SLO: <20.100ms -6.7%) vs baseline: -0.1% Memory: ✅ 65.452MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.118ms (SLO: <21.500ms -6.4%) vs baseline: -0.2% Memory: ✅ 65.501MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.292ms (SLO: <22.000ms -7.8%) vs baseline: ~same Memory: ✅ 65.483MB (SLO: <67.000MB -2.3%) vs baseline: +5.1% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.045ms (SLO: <19.850ms -9.1%) vs baseline: ~same Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.059ms (SLO: <19.400ms -6.9%) vs baseline: +0.1% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.059ms (SLO: <19.450ms -7.2%) vs baseline: +0.4% Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: -0.3% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.610ms (SLO: <6.750ms -2.1%) vs baseline: ~same Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.586ms (SLO: <4.750ms -3.5%) vs baseline: -0.5% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 45.554MB (SLO: <47.000MB -3.1%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: ~same Memory: ✅ 42.389MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.419MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.3% Memory: ✅ 52.302MB (SLO: <53.500MB -2.2%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: -0.3% Memory: ✅ 52.221MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: -0.1% Memory: ✅ 58.272MB (SLO: <60.000MB -2.9%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.714ms (SLO: <47.150ms 📉 -13.7%) vs baseline: +2.4% Memory: ✅ 44.206MB (SLO: <47.000MB -5.9%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 316.349ms (SLO: <344.800ms -8.3%) vs baseline: ~same Memory: ✅ 618.553MB (SLO: <630.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 287.886ms (SLO: <314.000ms -8.3%) vs baseline: +0.7% Memory: ✅ 619.651MB (SLO: <630.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 81.585ms (SLO: <92.350ms 📉 -11.7%) vs baseline: +3.1% Memory: ✅ 39.745MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 37.483ms (SLO: <44.500ms 📉 -15.8%) vs baseline: +1.3% Memory: ✅ 43.583MB (SLO: <47.500MB -8.2%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 57.567ms (SLO: <67.650ms 📉 -14.9%) vs baseline: +1.7% Memory: ✅ 40.127MB (SLO: <47.000MB 📉 -14.6%) vs baseline: +4.9% ✅ set-statusTime: ✅ 42.934ms (SLO: <50.400ms 📉 -14.8%) vs baseline: -0.1% Memory: ✅ 43.629MB (SLO: <47.000MB -7.2%) vs baseline: +5.0% ✅ startTime: ✅ 37.153ms (SLO: <43.450ms 📉 -14.5%) vs baseline: +2.0% Memory: ✅ 43.571MB (SLO: <47.000MB -7.3%) vs baseline: +4.8% ✅ start-finishTime: ✅ 80.208ms (SLO: <88.000ms -8.9%) vs baseline: +0.4% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 81.502ms (SLO: <89.000ms -8.4%) vs baseline: ~same Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.9% ✅ update-nameTime: ✅ 38.074ms (SLO: <45.150ms 📉 -15.7%) vs baseline: +0.4% Memory: ✅ 43.953MB (SLO: <47.000MB -6.5%) vs baseline: +4.9% 🟡 span - 26/26✅ add-eventTime: ✅ 20.551ms (SLO: <22.500ms -8.7%) vs baseline: +0.3% Memory: ✅ 49.694MB (SLO: <53.000MB -6.2%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 90.207ms (SLO: <93.500ms -3.5%) vs baseline: +0.3% Memory: ✅ 690.381MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.237ms (SLO: <155.000ms -5.0%) vs baseline: -0.3% Memory: ✅ 690.293MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 18.953ms (SLO: <20.500ms -7.5%) vs baseline: +0.5% Memory: ✅ 48.398MB (SLO: <53.000MB -8.7%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 19.190ms (SLO: <20.500ms -6.4%) vs baseline: +1.0% Memory: ✅ 48.377MB (SLO: <53.000MB -8.7%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 37.975ms (SLO: <40.000ms -5.1%) vs baseline: +1.1% Memory: ✅ 42.341MB (SLO: <53.000MB 📉 -20.1%) vs baseline: +4.6% ✅ set-statusTime: ✅ 20.612ms (SLO: <22.000ms -6.3%) vs baseline: +0.3% Memory: ✅ 48.457MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ startTime: ✅ 18.753ms (SLO: <20.500ms -8.5%) vs baseline: +0.7% Memory: ✅ 48.424MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ start-finishTime: ✅ 51.494ms (SLO: <52.500ms 🟡 -1.9%) vs baseline: +0.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 52.840ms (SLO: <54.500ms -3.0%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ start-finish-traceid128Time: ✅ 55.049ms (SLO: <57.000ms -3.4%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 19.056ms (SLO: <22.500ms 📉 -15.3%) vs baseline: +0.1% Memory: ✅ 48.446MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 19.118ms (SLO: <22.000ms 📉 -13.1%) vs baseline: ~same Memory: ✅ 49.074MB (SLO: <53.000MB -7.4%) vs baseline: +4.5%
|
This change removes the deprecated
non_active_span
parameter toHttpPropagator.inject
.Note the base branch, a staging area for breaking changes slated for 4.0.