-
Notifications
You must be signed in to change notification settings - Fork 462
chore(azure): add typing, call _finish_span, and use ddtrace.auto #14922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 3 ms. The average import time from base is: 250 ± 5 ms. The import time difference between this PR and base is: -7.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate duncan-harvey/azure-integrations-cleanup (ccd3bfe) with baseline main (23fe9e1) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.115µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.5% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 213.441µs (SLO: <250.000µs 📉 -14.6%) vs baseline: +0.7% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.172µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +9.0% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 191.250µs (SLO: <220.000µs 📉 -13.1%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.301µs (SLO: <20.000µs 📉 -88.5%) vs baseline: 📈 +10.7% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 124.531µs (SLO: <150.000µs 📉 -17.0%) vs baseline: +0.1% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.171µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +2.6% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 211.554µs (SLO: <250.000µs 📉 -15.4%) vs baseline: -0.9% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 21.362ms (SLO: <23.500ms -9.1%) vs baseline: -1.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.003ms (SLO: <2.250ms 📉 -11.0%) vs baseline: +1.4% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.288ms (SLO: <1.550ms 📉 -16.9%) vs baseline: ~same Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.209ms (SLO: <2.550ms 📉 -13.4%) vs baseline: +1.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.262µs (SLO: <20.000µs 📉 -78.7%) vs baseline: +1.1% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 181.394µs (SLO: <250.000µs 📉 -27.4%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.224ms (SLO: <2.500ms 📉 -11.0%) vs baseline: -0.1% Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.457ms (SLO: <22.300ms -8.3%) vs baseline: -0.1% Memory: ✅ 65.457MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: ~same Memory: ✅ 64.557MB (SLO: <67.000MB -3.6%) vs baseline: +4.9% ✅ iastTime: ✅ 20.403ms (SLO: <22.250ms -8.3%) vs baseline: -0.2% Memory: ✅ 65.441MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.284ms (SLO: <16.550ms -7.7%) vs baseline: +0.1% Memory: ✅ 53.770MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.602ms (SLO: <21.750ms -5.3%) vs baseline: +0.4% Memory: ✅ 65.485MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.139ms (SLO: <28.200ms -7.3%) vs baseline: -0.4% Memory: ✅ 67.562MB (SLO: <69.500MB -2.8%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.523ms (SLO: <21.750ms -5.6%) vs baseline: +0.1% Memory: ✅ 65.415MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.996ms (SLO: <23.500ms -6.4%) vs baseline: -0.4% Memory: ✅ 66.601MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.324ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.4% Memory: ✅ 65.433MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.642ms (SLO: <17.500ms -4.9%) vs baseline: -0.2% Memory: ✅ 65.403MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.494ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 71.353MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ tracer-no-cachesTime: ✅ 18.452ms (SLO: <19.650ms -6.1%) vs baseline: -0.4% Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.809ms (SLO: <20.100ms -6.4%) vs baseline: -0.1% Memory: ✅ 65.452MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.175ms (SLO: <21.500ms -6.2%) vs baseline: ~same Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.324ms (SLO: <22.000ms -7.6%) vs baseline: -0.2% Memory: ✅ 65.385MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.058ms (SLO: <19.850ms -9.0%) vs baseline: ~same Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.051ms (SLO: <19.400ms -7.0%) vs baseline: +0.1% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.179ms (SLO: <19.450ms -6.5%) vs baseline: +0.7% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.2% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.621ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.583ms (SLO: <4.750ms -3.5%) vs baseline: -0.4% Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +5.1% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.456MB (SLO: <47.000MB -3.3%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.863ms (SLO: <2.000ms -6.8%) vs baseline: -0.1% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.909ms (SLO: <2.100ms -9.1%) vs baseline: -0.5% Memory: ✅ 46.478MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: ~same Memory: ✅ 52.316MB (SLO: <53.500MB -2.2%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: +0.1% Memory: ✅ 52.219MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: +0.2% Memory: ✅ 58.287MB (SLO: <60.000MB -2.9%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.971ms (SLO: <47.150ms 📉 -13.1%) vs baseline: +0.3% Memory: ✅ 44.229MB (SLO: <47.000MB -5.9%) vs baseline: +5.1% ✅ add-metricsTime: ✅ 316.865ms (SLO: <344.800ms -8.1%) vs baseline: +0.3% Memory: ✅ 616.698MB (SLO: <630.000MB -2.1%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 286.583ms (SLO: <314.000ms -8.7%) vs baseline: -0.7% Memory: ✅ 618.361MB (SLO: <630.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.638ms (SLO: <92.350ms 📉 -12.7%) vs baseline: -0.1% Memory: ✅ 39.771MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 38.189ms (SLO: <44.500ms 📉 -14.2%) vs baseline: -0.6% Memory: ✅ 43.637MB (SLO: <47.500MB -8.1%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 58.498ms (SLO: <67.650ms 📉 -13.5%) vs baseline: +0.3% Memory: ✅ 40.110MB (SLO: <47.000MB 📉 -14.7%) vs baseline: +4.9% ✅ set-statusTime: ✅ 44.213ms (SLO: <50.400ms 📉 -12.3%) vs baseline: +0.3% Memory: ✅ 43.595MB (SLO: <47.000MB -7.2%) vs baseline: +5.0% ✅ startTime: ✅ 37.595ms (SLO: <43.450ms 📉 -13.5%) vs baseline: +0.3% Memory: ✅ 43.581MB (SLO: <47.000MB -7.3%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.614ms (SLO: <88.000ms -6.1%) vs baseline: ~same Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.019ms (SLO: <89.000ms -5.6%) vs baseline: +0.2% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ update-nameTime: ✅ 39.087ms (SLO: <45.150ms 📉 -13.4%) vs baseline: -0.6% Memory: ✅ 43.948MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% 🟡 span - 26/26✅ add-eventTime: ✅ 20.911ms (SLO: <22.500ms -7.1%) vs baseline: +2.6% Memory: ✅ 49.610MB (SLO: <53.000MB -6.4%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 91.640ms (SLO: <93.500ms 🟡 -2.0%) vs baseline: +1.1% Memory: ✅ 689.971MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.896ms (SLO: <155.000ms -4.6%) vs baseline: ~same Memory: ✅ 690.563MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.9% ✅ get-contextTime: ✅ 19.064ms (SLO: <20.500ms -7.0%) vs baseline: +0.5% Memory: ✅ 48.522MB (SLO: <53.000MB -8.4%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 19.057ms (SLO: <20.500ms -7.0%) vs baseline: ~same Memory: ✅ 48.436MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 38.863ms (SLO: <40.000ms -2.8%) vs baseline: +3.6% Memory: ✅ 42.476MB (SLO: <53.000MB 📉 -19.9%) vs baseline: +5.0% ✅ set-statusTime: ✅ 20.880ms (SLO: <22.000ms -5.1%) vs baseline: +0.7% Memory: ✅ 48.458MB (SLO: <53.000MB -8.6%) vs baseline: +4.6% ✅ startTime: ✅ 18.939ms (SLO: <20.500ms -7.6%) vs baseline: +1.3% Memory: ✅ 48.464MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ start-finishTime: ✅ 51.403ms (SLO: <52.500ms -2.1%) vs baseline: +0.4% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 52.814ms (SLO: <54.500ms -3.1%) vs baseline: -0.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ start-finish-traceid128Time: ✅ 55.046ms (SLO: <57.000ms -3.4%) vs baseline: ~same Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ start-traceid128Time: ✅ 19.221ms (SLO: <22.500ms 📉 -14.6%) vs baseline: +0.4% Memory: ✅ 48.453MB (SLO: <53.000MB -8.6%) vs baseline: +5.0% ✅ update-nameTime: ✅ 19.131ms (SLO: <22.000ms 📉 -13.0%) vs baseline: -0.2% Memory: ✅ 49.151MB (SLO: <53.000MB -7.3%) vs baseline: +4.8%
|
Description
For
azure_eventhubs
,azure_functions
,azure_servicebus
integrations:Testing
Uses existing test coverage, no additional testing needed
Risks
Additional Notes
Follows comments made in #14636 when adding
azure_eventhubs
integration