-
Notifications
You must be signed in to change notification settings - Fork 463
ci: relax span-start-finish-traceid128 SLO (#14917) [backport 3.16] #14930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.16
Are you sure you want to change the base?
Conversation
In PR #14773 we improved span start overhead and reduced the SLOs, but we may have been too aggressive with lowering the span-start-finish-traceid128 SLO. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers -->
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 3 ms. The average import time from base is: 243 ± 2 ms. The import time difference between this PR and base is: -1.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-14917-to-3.16 (3c172f3) with baseline 3.16 (ddf29d2) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.476ms (SLO: <22.300ms -8.2%) vs baseline: +0.1% Memory: ✅ 65.475MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.349ms (SLO: <1.450ms -7.0%) vs baseline: +0.3% Memory: ✅ 64.359MB (SLO: <67.000MB -3.9%) vs baseline: +4.7% ✅ iastTime: ✅ 20.422ms (SLO: <22.250ms -8.2%) vs baseline: ~same Memory: ✅ 65.544MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.282ms (SLO: <16.550ms -7.7%) vs baseline: +0.3% Memory: ✅ 53.749MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.571ms (SLO: <21.750ms -5.4%) vs baseline: +0.4% Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.084ms (SLO: <28.200ms -7.5%) vs baseline: -0.3% Memory: ✅ 68.337MB (SLO: <69.500MB 🟡 -1.7%) vs baseline: +5.9% ✅ tracerTime: ✅ 20.504ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 65.614MB (SLO: <67.000MB -2.1%) vs baseline: +5.2% ✅ tracer-and-profilerTime: ✅ 22.074ms (SLO: <23.500ms -6.1%) vs baseline: +0.2% Memory: ✅ 66.583MB (SLO: <67.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.308ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 65.549MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.606ms (SLO: <17.500ms -5.1%) vs baseline: ~same Memory: ✅ 65.449MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.468ms (SLO: <21.750ms -5.9%) vs baseline: +0.3% Memory: ✅ 71.461MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.421ms (SLO: <19.650ms -6.3%) vs baseline: ~same Memory: ✅ 65.537MB (SLO: <67.000MB -2.2%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.816ms (SLO: <20.100ms -6.4%) vs baseline: +0.3% Memory: ✅ 65.537MB (SLO: <67.000MB -2.2%) vs baseline: +5.2% ✅ tracer-no-middlewareTime: ✅ 20.171ms (SLO: <21.500ms -6.2%) vs baseline: ~same Memory: ✅ 65.579MB (SLO: <67.000MB -2.1%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.340ms (SLO: <22.000ms -7.5%) vs baseline: +0.5% Memory: ✅ 65.521MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.101ms (SLO: <19.850ms -8.8%) vs baseline: +0.2% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.326ms (SLO: <19.400ms -5.5%) vs baseline: +1.3% Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.111ms (SLO: <19.450ms -6.9%) vs baseline: -0.3% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.560ms (SLO: <4.750ms -4.0%) vs baseline: ~same Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.567ms (SLO: <6.750ms -2.7%) vs baseline: ~same Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.557ms (SLO: <4.750ms -4.1%) vs baseline: -0.5% Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.2% Memory: ✅ 45.416MB (SLO: <47.000MB -3.4%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.310MB (SLO: <49.000MB 📉 -13.7%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.907ms (SLO: <2.100ms -9.2%) vs baseline: ~same Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.376ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: +0.3% Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: +0.1% Memory: ✅ 58.351MB (SLO: <60.000MB -2.7%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.506ms (SLO: <47.150ms -9.8%) vs baseline: +0.3% Memory: ✅ 44.530MB (SLO: <47.000MB -5.3%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 318.099ms (SLO: <344.800ms -7.7%) vs baseline: +0.2% Memory: ✅ 595.796MB (SLO: <600.000MB 🟡 -0.7%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 289.129ms (SLO: <314.000ms -7.9%) vs baseline: +0.9% Memory: ✅ 596.951MB (SLO: <600.000MB 🟡 -0.5%) vs baseline: +4.8% ✅ get-contextTime: ✅ 82.870ms (SLO: <92.350ms 📉 -10.3%) vs baseline: +3.4% Memory: ✅ 40.030MB (SLO: <46.500MB 📉 -13.9%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 39.200ms (SLO: <44.500ms 📉 -11.9%) vs baseline: +0.6% Memory: ✅ 44.013MB (SLO: <47.500MB -7.3%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 59.824ms (SLO: <67.650ms 📉 -11.6%) vs baseline: +1.5% Memory: ✅ 40.278MB (SLO: <47.000MB 📉 -14.3%) vs baseline: +4.7% ✅ set-statusTime: ✅ 44.820ms (SLO: <50.400ms 📉 -11.1%) vs baseline: -0.2% Memory: ✅ 44.011MB (SLO: <47.000MB -6.4%) vs baseline: +5.0% ✅ startTime: ✅ 38.256ms (SLO: <43.450ms 📉 -12.0%) vs baseline: +0.2% Memory: ✅ 43.973MB (SLO: <47.000MB -6.4%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.437ms (SLO: <88.000ms -6.3%) vs baseline: -0.2% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 84.063ms (SLO: <89.000ms -5.5%) vs baseline: -0.2% Memory: ✅ 34.603MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 40.260ms (SLO: <45.150ms 📉 -10.8%) vs baseline: ~same Memory: ✅ 44.275MB (SLO: <47.000MB -5.8%) vs baseline: +5.0% 🟡 span - 26/26✅ add-eventTime: ✅ 20.620ms (SLO: <22.500ms -8.4%) vs baseline: -0.9% Memory: ✅ 50.240MB (SLO: <53.000MB -5.2%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 91.071ms (SLO: <93.500ms -2.6%) vs baseline: -0.5% Memory: ✅ 660.955MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.689ms (SLO: <155.000ms -4.7%) vs baseline: -0.4% Memory: ✅ 660.768MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.7% ✅ get-contextTime: ✅ 19.286ms (SLO: <20.500ms -5.9%) vs baseline: -0.3% Memory: ✅ 49.164MB (SLO: <53.000MB -7.2%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 19.556ms (SLO: <20.500ms -4.6%) vs baseline: -0.4% Memory: ✅ 49.085MB (SLO: <53.000MB -7.4%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.354ms (SLO: <40.000ms -4.1%) vs baseline: +0.2% Memory: ✅ 42.736MB (SLO: <53.000MB 📉 -19.4%) vs baseline: +4.9% ✅ set-statusTime: ✅ 21.222ms (SLO: <22.000ms -3.5%) vs baseline: -0.1% Memory: ✅ 49.060MB (SLO: <53.000MB -7.4%) vs baseline: +4.5% ✅ startTime: ✅ 19.309ms (SLO: <20.500ms -5.8%) vs baseline: -0.1% Memory: ✅ 49.029MB (SLO: <53.000MB -7.5%) vs baseline: +4.7% ✅ start-finishTime: ✅ 51.640ms (SLO: <52.500ms 🟡 -1.6%) vs baseline: +0.9% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ start-finish-telemetryTime: ✅ 52.872ms (SLO: <54.500ms -3.0%) vs baseline: +0.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ start-finish-traceid128Time: ✅ 54.940ms (SLO: <57.000ms -3.6%) vs baseline: +0.3% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 19.801ms (SLO: <22.500ms 📉 -12.0%) vs baseline: +0.6% Memory: ✅ 49.041MB (SLO: <53.000MB -7.5%) vs baseline: +4.9% ✅ update-nameTime: ✅ 20.200ms (SLO: <22.000ms -8.2%) vs baseline: +0.4% Memory: ✅ 49.754MB (SLO: <53.000MB -6.1%) vs baseline: +4.8%
|
In PR #14773 we improved span start overhead and reduced the SLOs, but we may have been too aggressive with lowering the
span-start-finish-traceid128 SLO.