-
Notifications
You must be signed in to change notification settings - Fork 463
fix(profiling): adapt Stack V2 to exception-free Echion #14933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(profiling): adapt Stack V2 to exception-free Echion #14933
Conversation
4063724
to
6c80385
Compare
|
6c80385
to
68f1350
Compare
68f1350
to
8a9d043
Compare
8a9d043
to
2f846d5
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 2 ms. The average import time from base is: 252 ± 7 ms. The import time difference between this PR and base is: -12.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
…eption-free-echion
Performance SLOsComparing candidate kowalski/fix-profiling-adapt-stack-v2-to-exception-free-echion (801511c) with baseline main (c332ef9) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.9% Memory: ✅ 37.945MB (SLO: <39.000MB -2.7%) vs baseline: +4.5% ✅ add_inplace_noaspectTime: ✅ 0.322µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.2% Memory: ✅ 38.004MB (SLO: <39.000MB -2.6%) vs baseline: +4.6% ✅ add_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.3% Memory: ✅ 37.965MB (SLO: <39.000MB -2.7%) vs baseline: +4.5% ✅ bytearray_aspectTime: ✅ 1.331µs (SLO: <10.000µs 📉 -86.7%) vs baseline: +0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.453µs (SLO: <10.000µs 📉 -85.5%) vs baseline: -0.8% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.3% ✅ bytearray_extend_noaspectTime: ✅ 0.612µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +3.8% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.284µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.2% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.5% Memory: ✅ 38.004MB (SLO: <39.000MB -2.6%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.3% Memory: ✅ 37.965MB (SLO: <39.000MB -2.7%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.2% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 37.985MB (SLO: <39.000MB -2.6%) vs baseline: +4.5% ✅ encode_aspectTime: ✅ 0.706µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 37.906MB (SLO: <39.000MB -2.8%) vs baseline: +4.4% ✅ format_aspectTime: ✅ 3.397µs (SLO: <10.000µs 📉 -66.0%) vs baseline: +0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 3.631µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -1.5% Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +4.4% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -1.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.1% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.503µs (SLO: <20.000µs 📉 -87.5%) vs baseline: +0.8% Memory: ✅ 37.965MB (SLO: <39.000MB -2.7%) vs baseline: +4.4% ✅ ljust_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.7% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 2.212µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 2.246µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -0.4% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 0.994µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -0.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.539µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.5% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ modulo_aspect_for_bytesTime: ✅ 0.973µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -0.5% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.202µs (SLO: <10.000µs 📉 -88.0%) vs baseline: +0.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same Memory: ✅ 37.985MB (SLO: <39.000MB -2.6%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 4.806µs (SLO: <10.000µs 📉 -51.9%) vs baseline: ~same Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.2% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 0.903µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.4% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.930µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.3% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.4% Memory: ✅ 37.926MB (SLO: <39.000MB -2.8%) vs baseline: +4.5% ✅ stringio_aspectTime: ✅ 1.520µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.2% ✅ stringio_noaspectTime: ✅ 0.723µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.2% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.535µs (SLO: <20.000µs 📉 -87.3%) vs baseline: 📈 +14.1% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.433µs (SLO: <10.000µs 📉 -75.7%) vs baseline: ~same Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 0.544µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.9% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.362µs (SLO: <10.000µs 📉 -76.4%) vs baseline: -0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.509µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +0.3% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.443µs (SLO: <10.000µs 📉 -65.6%) vs baseline: +6.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.4% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.233µs (SLO: <10.000µs 📉 -77.7%) vs baseline: +1.1% Memory: ✅ 38.004MB (SLO: <39.000MB -2.6%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.283µs (SLO: <10.000µs 📉 -57.2%) vs baseline: -1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.090µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.808µs (SLO: <10.000µs 📉 -31.9%) vs baseline: 📈 +10.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.307µs (SLO: <10.000µs 📉 -76.9%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.471µs (SLO: <10.000µs 📉 -65.3%) vs baseline: -0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -2.1% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.903µs (SLO: <10.000µs 📉 -51.0%) vs baseline: +0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.889µs (SLO: <10.000µs 📉 -61.1%) vs baseline: +6.5% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.699µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.6% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.571µs (SLO: <10.000µs 📉 -54.3%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.7% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.476ms (SLO: <22.300ms -8.2%) vs baseline: -0.1% Memory: ✅ 65.389MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: -0.4% Memory: ✅ 64.629MB (SLO: <67.000MB -3.5%) vs baseline: +4.9% ✅ iastTime: ✅ 20.448ms (SLO: <22.250ms -8.1%) vs baseline: ~same Memory: ✅ 65.474MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.323ms (SLO: <16.550ms -7.4%) vs baseline: +0.4% Memory: ✅ 53.791MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 20.576ms (SLO: <21.750ms -5.4%) vs baseline: +0.3% Memory: ✅ 65.533MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.360ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 67.516MB (SLO: <69.500MB -2.9%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.485ms (SLO: <21.750ms -5.8%) vs baseline: -0.2% Memory: ✅ 65.512MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.036ms (SLO: <23.500ms -6.2%) vs baseline: -0.1% Memory: ✅ 66.625MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.306ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 65.498MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.613ms (SLO: <17.500ms -5.1%) vs baseline: ~same Memory: ✅ 65.114MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.2% ✅ tracer-nativeTime: ✅ 20.467ms (SLO: <21.750ms -5.9%) vs baseline: +0.3% Memory: ✅ 71.506MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 18.443ms (SLO: <19.650ms -6.1%) vs baseline: -0.2% Memory: ✅ 65.447MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.866ms (SLO: <20.100ms -6.1%) vs baseline: +0.5% Memory: ✅ 65.098MB (SLO: <67.000MB -2.8%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.173ms (SLO: <21.500ms -6.2%) vs baseline: ~same Memory: ✅ 65.534MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.331ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 65.498MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.005ms (SLO: <19.850ms -9.3%) vs baseline: -0.4% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.021ms (SLO: <19.400ms -7.1%) vs baseline: -0.3% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.022ms (SLO: <19.450ms -7.3%) vs baseline: -0.2% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: +0.5% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.604ms (SLO: <6.750ms -2.2%) vs baseline: ~same Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.606ms (SLO: <4.750ms -3.0%) vs baseline: +0.6% Memory: ✅ 62.049MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.852ms (SLO: <2.000ms -7.4%) vs baseline: ~same Memory: ✅ 45.416MB (SLO: <47.000MB -3.4%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.877ms (SLO: <2.000ms -6.1%) vs baseline: +0.5% Memory: ✅ 42.330MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: +0.2% Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 3.380ms (SLO: <3.650ms -7.4%) vs baseline: +0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: -0.1% Memory: ✅ 58.292MB (SLO: <60.000MB -2.8%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 41.116ms (SLO: <47.150ms 📉 -12.8%) vs baseline: +0.2% Memory: ✅ 44.199MB (SLO: <47.000MB -6.0%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 316.194ms (SLO: <344.800ms -8.3%) vs baseline: ~same Memory: ✅ 616.702MB (SLO: <630.000MB -2.1%) vs baseline: +4.6% ✅ add-tagsTime: ✅ 290.067ms (SLO: <314.000ms -7.6%) vs baseline: +0.4% Memory: ✅ 618.471MB (SLO: <630.000MB 🟡 -1.8%) vs baseline: +4.7% ✅ get-contextTime: ✅ 80.690ms (SLO: <92.350ms 📉 -12.6%) vs baseline: -0.2% Memory: ✅ 39.718MB (SLO: <46.500MB 📉 -14.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 38.491ms (SLO: <44.500ms 📉 -13.5%) vs baseline: +0.7% Memory: ✅ 43.530MB (SLO: <47.500MB -8.4%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 58.401ms (SLO: <67.650ms 📉 -13.7%) vs baseline: -0.3% Memory: ✅ 40.161MB (SLO: <47.000MB 📉 -14.6%) vs baseline: +5.0% ✅ set-statusTime: ✅ 44.113ms (SLO: <50.400ms 📉 -12.5%) vs baseline: +0.2% Memory: ✅ 43.543MB (SLO: <47.000MB -7.4%) vs baseline: +4.7% ✅ startTime: ✅ 37.671ms (SLO: <43.450ms 📉 -13.3%) vs baseline: +0.6% Memory: ✅ 43.563MB (SLO: <47.000MB -7.3%) vs baseline: +4.7% ✅ start-finishTime: ✅ 82.728ms (SLO: <88.000ms -6.0%) vs baseline: +0.3% Memory: ✅ 34.642MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 83.821ms (SLO: <89.000ms -5.8%) vs baseline: -0.4% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 39.158ms (SLO: <45.150ms 📉 -13.3%) vs baseline: ~same Memory: ✅ 43.902MB (SLO: <47.000MB -6.6%) vs baseline: +4.7% 🟡 span - 26/26✅ add-eventTime: ✅ 20.990ms (SLO: <22.500ms -6.7%) vs baseline: +2.5% Memory: ✅ 49.705MB (SLO: <53.000MB -6.2%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 90.801ms (SLO: <93.500ms -2.9%) vs baseline: +1.0% Memory: ✅ 689.979MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 148.544ms (SLO: <155.000ms -4.2%) vs baseline: +0.8% Memory: ✅ 689.911MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.7% ✅ get-contextTime: ✅ 19.047ms (SLO: <20.500ms -7.1%) vs baseline: +0.9% Memory: ✅ 48.448MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 19.205ms (SLO: <20.500ms -6.3%) vs baseline: +0.2% Memory: ✅ 48.438MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 37.963ms (SLO: <40.000ms -5.1%) vs baseline: +1.2% Memory: ✅ 42.507MB (SLO: <53.000MB 📉 -19.8%) vs baseline: +5.0% ✅ set-statusTime: ✅ 21.031ms (SLO: <22.000ms -4.4%) vs baseline: +2.0% Memory: ✅ 48.368MB (SLO: <53.000MB -8.7%) vs baseline: +4.7% ✅ startTime: ✅ 18.965ms (SLO: <20.500ms -7.5%) vs baseline: +1.0% Memory: ✅ 48.410MB (SLO: <53.000MB -8.7%) vs baseline: +4.8% ✅ start-finishTime: ✅ 51.982ms (SLO: <52.500ms 🟡 -1.0%) vs baseline: +1.1% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 52.944ms (SLO: <54.500ms -2.9%) vs baseline: +0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ start-finish-traceid128Time: ✅ 55.455ms (SLO: <57.000ms -2.7%) vs baseline: +0.5% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ start-traceid128Time: ✅ 19.332ms (SLO: <22.500ms 📉 -14.1%) vs baseline: +1.0% Memory: ✅ 48.477MB (SLO: <53.000MB -8.5%) vs baseline: +5.0% ✅ update-nameTime: ✅ 19.388ms (SLO: <22.000ms 📉 -11.9%) vs baseline: +0.3% Memory: ✅ 49.142MB (SLO: <53.000MB -7.3%) vs baseline: +4.8%
|
What does this PR do?
This PR updates Echion to use the latest version (exception-free error reporting). It also updates the Stack V2 code to properly handle errors without try-catch blocks, using the new
Result
type we introduced. Fixes a bug in echion that could result in unbounded memory allocations, causing an OOM.Related
See comparison here P403n1x87/echion@3ebeb3e...7a368c1